Skip to content

Commit 8ca92dd

Browse files
dustymabejlebon
authored andcommitted
cmd-osbuild: add comment for relevance of rootful codepath
This came up in the prior code review [1] and we agreed to add the comment as a followon PR. [1] #4251 (comment)
1 parent a004c24 commit 8ca92dd

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/cmd-osbuild

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,10 @@ main() {
398398

399399
outdir=$(mktemp -p "${tmp_builddir}" -d)
400400
if has_privileges && [ "${COSA_NO_KVM:-}" == "1" ]; then
401-
cmd="env" # run outside of supermin if we are root already
401+
# Run outside of supermin if we are root already. This is useful
402+
# mostly on riscv where /dev/kvm isn't really supported by any
403+
# hardware right now (2025/08).
404+
cmd="env"
402405
else
403406
cmd="runvm_with_cache"
404407
fi

0 commit comments

Comments
 (0)