cmd-build-with-buildah: retain overrides/ API functionality #4256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly implements the overrides/ API functionality for cmd-build-with-buildah, aligning it with existing behavior in cosa. The change is straightforward and well-implemented. I have one suggestion to improve the robustness of the check for RPMs before creating a repository, which also improves consistency with other parts of the codebase.
`build-rootfs` in f-c-c learned a new `overrides/` API that matches how it works in cosa. Use that API to proxy through the cosa workdir `overrides/` dir.
jlebon
force-pushed
the
pr/bind-mount-overrides
branch
from
46898b5 to
8549db6
Compare
Right now, it's an anonymous image, which is awkward. Just add a proper
tag for it so it can more easily be used as is.
I initially tried to just add another `-t` so buildah would output both
a containers-storage tag and an OCI archive, but buildah gets confused
by the first `-t` referring to an OCI archive:
WARN[0001] don't know how to add tags to images stored in "oci-archive" transport
Will file an issue at some point.
While we're here, also echo the buildah command being run.
This is used by the pipeline for some reason. We could probably rip it out of there, but the dev case I think has value, so just add it.
My Python LSP is complaining about this.
This is known to not work but let's just no-op for now here instead of having to add conditional logic in the pipeline.
Member
|
I have local overrides from the recent Ignition PoC I was doing: Which seems to hit an error when building: |
Member
|
I ran with the updates from
and everything worked great! |
dustymabe
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-rootfsin f-c-c learned a newoverrides/API that matches how it works in cosa. Use that API to proxy through the cosa workdiroverrides/dir.