-
Notifications
You must be signed in to change notification settings - Fork 184
chore(deps): update dependency fedora to v43 #4348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh03 <206760901+red-hat-konflux-kflux-prd-rh03[bot]@users.noreply.github.com>
|
@aaradhak - there are some manual steps required here. Let me know if you need help. |
|
I think @marmijo is looking into this cosa bump part. |
I think #4366 should unblock this PR. |
|
I think the prow jobs need some updates too so we'll probably have to ignore/override those tests to merge this. Not sure if we have that documented anywhere. |
dustymabe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
3986428 to
5784f71
Compare
dustymabe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
looks like newer versions of linting libraries in F43 are stricter and there's a little cleanup for us to do. |
5784f71 to
120e6a9
Compare
120e6a9 to
a167f45
Compare
pylint is treating GObject-introspected methods (from gi.repository) as unbound instance methods that require a self argument, even though at runtime these calls are valid and work as expected. This causes false positive E1120 (no-value-for-parameter) errors on calls such as RpmOstree.get_basearch() and Json.Generator.new(). Add disable comments to the affected GI calls to keep pylint from complaining while preserving the existing behavior.
a167f45 to
86974da
Compare
|
/retest-required |
dustymabe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR contains the following updates:
42->43Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.