Skip to content

Commit bbf6644

Browse files
committed
re-add getter for test compatibility
1 parent 296b5ea commit bbf6644

File tree

3 files changed

+21
-39
lines changed

3 files changed

+21
-39
lines changed

evmd/app.go

Lines changed: 13 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import (
44
"encoding/json"
55
"errors"
66
"fmt"
7-
7+
precisebankkeeper "github.com/cosmos/evm/x/precisebank/keeper"
88
"io"
99

1010
"os"
@@ -40,9 +40,6 @@ import (
4040
"github.com/cosmos/evm/x/ibc/transfer"
4141
transferkeeper "github.com/cosmos/evm/x/ibc/transfer/keeper"
4242
transferv2 "github.com/cosmos/evm/x/ibc/transfer/v2"
43-
"github.com/cosmos/evm/x/precisebank"
44-
precisebankkeeper "github.com/cosmos/evm/x/precisebank/keeper"
45-
precisebanktypes "github.com/cosmos/evm/x/precisebank/types"
4643
"github.com/cosmos/evm/x/vm"
4744
evmkeeper "github.com/cosmos/evm/x/vm/keeper"
4845
evmtypes "github.com/cosmos/evm/x/vm/types"
@@ -187,11 +184,10 @@ type EVMD struct {
187184
CallbackKeeper ibccallbackskeeper.ContractKeeper
188185

189186
// Cosmos EVM keepers
190-
FeeMarketKeeper feemarketkeeper.Keeper
191-
EVMKeeper *evmkeeper.Keeper
192-
Erc20Keeper erc20keeper.Keeper
193-
PreciseBankKeeper precisebankkeeper.Keeper
194-
EVMMempool *evmmempool.ExperimentalEVMMempool
187+
FeeMarketKeeper feemarketkeeper.Keeper
188+
EVMKeeper *evmkeeper.Keeper
189+
Erc20Keeper erc20keeper.Keeper
190+
EVMMempool *evmmempool.ExperimentalEVMMempool
195191

196192
// the module manager
197193
ModuleManager *module.Manager
@@ -242,7 +238,7 @@ func NewExampleApp(
242238
// ibc keys
243239
ibcexported.StoreKey, ibctransfertypes.StoreKey,
244240
// Cosmos EVM store keys
245-
evmtypes.StoreKey, feemarkettypes.StoreKey, erc20types.StoreKey, precisebanktypes.StoreKey,
241+
evmtypes.StoreKey, feemarkettypes.StoreKey, erc20types.StoreKey,
246242
)
247243

248244
tkeys := storetypes.NewTransientStoreKeys(evmtypes.TransientKey, feemarkettypes.TransientKey)
@@ -405,7 +401,7 @@ func NewExampleApp(
405401

406402
app.GovKeeper = *govKeeper.SetHooks(
407403
govtypes.NewMultiGovHooks(
408-
// register the governance hooks
404+
// register the governance hooks
409405
),
410406
)
411407

@@ -428,16 +424,6 @@ func NewExampleApp(
428424
tkeys[feemarkettypes.TransientKey],
429425
)
430426

431-
// Set up PreciseBank keeper
432-
//
433-
// NOTE: PreciseBank is not needed if SDK use 18 decimals for gas coin. Use BankKeeper instead.
434-
app.PreciseBankKeeper = precisebankkeeper.NewKeeper(
435-
appCodec,
436-
keys[precisebanktypes.StoreKey],
437-
app.BankKeeper,
438-
app.AccountKeeper,
439-
)
440-
441427
// Set up EVM keeper
442428
tracer := cast.ToString(appOpts.Get(srvflags.EVMTracer))
443429

@@ -447,7 +433,7 @@ func NewExampleApp(
447433
appCodec, keys[evmtypes.StoreKey], tkeys[evmtypes.TransientKey], keys,
448434
authtypes.NewModuleAddress(govtypes.ModuleName),
449435
app.AccountKeeper,
450-
app.PreciseBankKeeper,
436+
app.BankKeeper,
451437
app.StakingKeeper,
452438
app.FeeMarketKeeper,
453439
&app.ConsensusParamsKeeper,
@@ -458,7 +444,7 @@ func NewExampleApp(
458444
precompiletypes.DefaultStaticPrecompiles(
459445
*app.StakingKeeper,
460446
app.DistrKeeper,
461-
app.PreciseBankKeeper,
447+
app.BankKeeper,
462448
&app.Erc20Keeper,
463449
&app.TransferKeeper,
464450
app.IBCKeeper.ChannelKeeper,
@@ -473,7 +459,7 @@ func NewExampleApp(
473459
appCodec,
474460
authtypes.NewModuleAddress(govtypes.ModuleName),
475461
app.AccountKeeper,
476-
app.PreciseBankKeeper,
462+
app.BankKeeper,
477463
app.EVMKeeper,
478464
app.StakingKeeper,
479465
&app.TransferKeeper,
@@ -572,7 +558,6 @@ func NewExampleApp(
572558
vm.NewAppModule(app.EVMKeeper, app.AccountKeeper, app.BankKeeper, app.AccountKeeper.AddressCodec()),
573559
feemarket.NewAppModule(app.FeeMarketKeeper),
574560
erc20.NewAppModule(app.Erc20Keeper, app.AccountKeeper),
575-
precisebank.NewAppModule(app.PreciseBankKeeper, app.BankKeeper, app.AccountKeeper),
576561
)
577562

578563
// BasicModuleManager defines the module BasicManager which is in charge of setting up basic,
@@ -620,7 +605,6 @@ func NewExampleApp(
620605
authtypes.ModuleName, banktypes.ModuleName, govtypes.ModuleName, genutiltypes.ModuleName,
621606
authz.ModuleName, feegrant.ModuleName,
622607
consensusparamtypes.ModuleName,
623-
precisebanktypes.ModuleName,
624608
vestingtypes.ModuleName,
625609
)
626610

@@ -639,7 +623,6 @@ func NewExampleApp(
639623
slashingtypes.ModuleName, minttypes.ModuleName,
640624
genutiltypes.ModuleName, evidencetypes.ModuleName, authz.ModuleName,
641625
feegrant.ModuleName, upgradetypes.ModuleName, consensusparamtypes.ModuleName,
642-
precisebanktypes.ModuleName,
643626
vestingtypes.ModuleName,
644627
)
645628

@@ -659,7 +642,6 @@ func NewExampleApp(
659642
evmtypes.ModuleName,
660643
feemarkettypes.ModuleName,
661644
erc20types.ModuleName,
662-
precisebanktypes.ModuleName,
663645

664646
ibctransfertypes.ModuleName,
665647
genutiltypes.ModuleName, evidencetypes.ModuleName, authz.ModuleName,
@@ -1065,7 +1047,9 @@ func (app *EVMD) GetMintKeeper() mintkeeper.Keeper {
10651047
}
10661048

10671049
func (app *EVMD) GetPreciseBankKeeper() *precisebankkeeper.Keeper {
1068-
return &app.PreciseBankKeeper
1050+
return nil
1051+
// Uncomment if using PreciseBank
1052+
//return &app.PreciseBankKeeper
10691053
}
10701054

10711055
func (app *EVMD) GetCallbackKeeper() ibccallbackskeeper.ContractKeeper {

evmd/tests/integration/x_precisebank_test.go

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,16 @@ package integration
22

33
import (
44
"testing"
5-
6-
"github.com/stretchr/testify/suite"
7-
8-
"github.com/cosmos/evm/tests/integration/x/precisebank"
95
)
106

117
func TestPreciseBankGenesis(t *testing.T) {
12-
s := precisebank.NewGenesisTestSuite(CreateEvmd)
13-
suite.Run(t, s)
8+
// Uncomment these lines if using PreciseBank
9+
//s := precisebank.NewGenesisTestSuite(CreateEvmd)
10+
//suite.Run(t, s)
1411
}
1512

1613
func TestPreciseBankKeeper(t *testing.T) {
17-
s := precisebank.NewKeeperIntegrationTestSuite(CreateEvmd)
18-
suite.Run(t, s)
14+
// Uncomment these lines if using PreciseBank
15+
//s := precisebank.NewKeeperIntegrationTestSuite(CreateEvmd)
16+
//suite.Run(t, s)
1917
}

interfaces.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ package evm
22

33
import (
44
"encoding/json"
5+
precisebankkeeper "github.com/cosmos/evm/x/precisebank/keeper"
56

67
erc20keeper "github.com/cosmos/evm/x/erc20/keeper"
78
feemarketkeeper "github.com/cosmos/evm/x/feemarket/keeper"
89
"github.com/cosmos/evm/x/ibc/callbacks/keeper"
910
transferkeeper "github.com/cosmos/evm/x/ibc/transfer/keeper"
10-
precisebankkeeper "github.com/cosmos/evm/x/precisebank/keeper"
1111
evmkeeper "github.com/cosmos/evm/x/vm/keeper"
1212
ibctesting "github.com/cosmos/ibc-go/v10/testing"
1313

@@ -50,7 +50,6 @@ type EvmApp interface { //nolint:revive
5050
GetDistrKeeper() distrkeeper.Keeper
5151
GetStakingKeeper() *stakingkeeper.Keeper
5252
GetMintKeeper() mintkeeper.Keeper
53-
GetPreciseBankKeeper() *precisebankkeeper.Keeper
5453
GetFeeGrantKeeper() feegrantkeeper.Keeper
5554
GetConsensusParamsKeeper() consensusparamkeeper.Keeper
5655
GetCallbackKeeper() keeper.ContractKeeper
@@ -61,4 +60,5 @@ type EvmApp interface { //nolint:revive
6160
GetAnteHandler() sdk.AnteHandler
6261
MsgServiceRouter() *baseapp.MsgServiceRouter
6362
GetMempool() mempool.ExtMempool
63+
GetPreciseBankKeeper() *precisebankkeeper.Keeper
6464
}

0 commit comments

Comments
 (0)