Skip to content

Commit 98025a1

Browse files
Bump cpp-linter from 1.7.1 to 1.7.2 (#193)
* Bump cpp-linter from 1.7.1 to 1.7.2 Bumps [cpp-linter](https://github.com/cpp-linter/cpp-linter) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/cpp-linter/cpp-linter/releases) - [Commits](cpp-linter/cpp-linter@v1.7.1...v1.7.2) --- updated-dependencies: - dependency-name: cpp-linter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * revised README --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brendan <2bndy5@gmail.com>
1 parent 58a12d1 commit 98025a1

File tree

2 files changed

+24
-11
lines changed

2 files changed

+24
-11
lines changed

README.md

Lines changed: 23 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
[![MkDocs Deploy](https://github.com/cpp-linter/cpp-linter-action/actions/workflows/mkdocs-deploy.yml/badge.svg)](https://github.com/cpp-linter/cpp-linter-action/actions/workflows/mkdocs-deploy.yml)
99
![GitHub](https://img.shields.io/github/license/cpp-linter/cpp-linter-action?label=license&logo=github)
1010

11-
A Github Action for linting C/C++ code integrating clang-tidy and clang-format to collect feedback provided in the form of annotations, thread comments, and step summary.
11+
A Github Action for linting C/C++ code integrating clang-tidy and clang-format to collect feedback provided in the form of [`file-annotations`](#file-annotations), [`thread-comments`](#thread-comments), workflow [`step-summary`](#step-summary), and Pull Request reviews (with [`tidy-review`](#tidy-review) or [`format-review`](#format-review)).
1212

1313
> [!WARNING]
1414
> We only support Linux runners using a Debian based Linux OS (like Ubuntu and many others).
@@ -20,8 +20,8 @@ A Github Action for linting C/C++ code integrating clang-tidy and clang-format t
2020
v2
2121

2222
* Change action from using docker to composite steps
23-
* improve workflow runs times from 1m 24s (currently) to 6-20s.
24-
* better support for the database input option (which is currently broken with the docker env).
23+
* improve workflow runs times from 1m 24s (using v1) to 6-20s (for simple workflow runs).
24+
* better support for the database input option (which was broken with the docker environment in v1).
2525
* better support cross-compilation
2626
* better support 3rd party libraries
2727
* Includes many issues and enhancements. See [#87](https://github.com/cpp-linter/cpp-linter-action/issues/87) for details.
@@ -148,16 +148,17 @@ jobs:
148148

149149
#### `no-lgtm`
150150

151-
- **Description**: Set this option to true or false to enable or disable the use of a thread comment that basically says 'Looks Good To Me' (when all checks pass).
152-
- See `thread-comments` option for further details.
151+
- **Description**: Set this option to true or false to enable or disable the use of a thread comment or pull request review that basically says 'Looks Good To Me' (when all checks pass).
152+
- See [`thread-comments`](#thread-comments), [`tidy-review`](#tidy-review), and [`format-review`](#format-review) options for further details.
153153
- Default: true (meaning no LGTM comment used)
154154

155155
#### `step-summary`
156156

157157
- **Description**: Set this option to true to append content as part of workflow's job summary.
158158
- See implementation details in GitHub's documentation about
159159
[Adding a job summary](https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary).
160-
This option is independent of the `thread-comments` option, rather this option uses the same content that the `thread-comments` option would use.
160+
This option is independent of the [`thread-comments`](#thread-comments) option, rather this option uses the same content that the [`thread-comments`](#thread-comments) option would use.
161+
- Note: The [`no-lgtm`](#no-lgtm) option is _not_ applied to step summaries.
161162
- Default: false
162163

163164
#### `file-annotations`
@@ -179,18 +180,20 @@ jobs:
179180

180181
**Beta feature** 🚧
181182

182-
- **Description**: Set this option to true to enable pull request reviews from clang-tidy.
183+
- **Description**: Set this option to true to enable Pull Request reviews from clang-tidy.
183184
- To use Pull Request reviews, the `GITHUB_TOKEN` (provided by Github to each repository) must be declared as an environment
184185
variable. See [Authenticating with the GITHUB_TOKEN](https://docs.github.com/en/actions/reference/authentication-in-a-workflow)
185186
- See also [the PR review feature caveats](https://cpp-linter.github.io/cpp-linter/pr_review_caveats.html)
187+
- Note: The [`no-lgtm`](#no-lgtm) option is applicable to Pull Request reviews.
186188
- Default: false
187189

188190
#### `format-review`
189191

190-
- **Description**: Set this option to true to enable pull request reviews from clang-format.
192+
- **Description**: Set this option to true to enable Pull Request reviews from clang-format.
191193
- To use Pull Request reviews, the `GITHUB_TOKEN` (provided by Github to each repository) must be declared as an environment
192194
variable. See [Authenticating with the GITHUB_TOKEN](https://docs.github.com/en/actions/reference/authentication-in-a-workflow)
193195
- See also [the PR review feature caveats](https://cpp-linter.github.io/cpp-linter/pr_review_caveats.html)
196+
- Note: The [`no-lgtm`](#no-lgtm) option is applicable to Pull Request reviews.
194197
- Default: false
195198

196199
### Outputs
@@ -215,25 +218,35 @@ The total number of concerns raised by clang-format only.
215218

216219
### Annotations
217220

221+
Using [`file-annotations`](#file-annotations):
222+
223+
#### clang-format annotations
224+
218225
![clang-format annotations](https://raw.githubusercontent.com/cpp-linter/cpp-linter-action/main/docs/images/annotations-clang-format.png)
219226

227+
#### clang-tidy annotations
228+
220229
![clang-tidy annotations](https://raw.githubusercontent.com/cpp-linter/cpp-linter-action/main/docs/images/annotations-clang-tidy.png)
221230

222231
### Thread Comment
223232

233+
Using [`thread-comments`](#thread-comments):
234+
224235
![sample comment](https://raw.githubusercontent.com/cpp-linter/cpp-linter-action/main/docs/images/comment.png)
225236

226237
### Step Summary
227238

239+
Using [`step-summary`](#step-summary):
240+
228241
![step summary](https://raw.githubusercontent.com/cpp-linter/cpp-linter-action/main/docs/images/step-summary.png)
229242

230243
### Pull Request Review
231244

232-
Using only clang-tidy (`tidy-review`):
245+
Using only clang-tidy ([`tidy-review`](#tidy-review)):
233246

234247
![sample tidy-review](https://raw.githubusercontent.com/cpp-linter/cpp-linter-action/main/docs/images/tidy-review.png)
235248

236-
Using only clang-format (`format-review`):
249+
Using only clang-format ([`format-review`](#format-review)):
237250

238251
![sample format-review](https://raw.githubusercontent.com/cpp-linter/cpp-linter-action/main/docs/images/format-review.png)
239252

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ clang-tools==0.11.1
44

55
# cpp-linter core Python executable package
66
# For details please see: https://github.com/cpp-linter/cpp-linter
7-
cpp-linter==1.7.1
7+
cpp-linter==1.7.2

0 commit comments

Comments
 (0)