[5.x]: Country Name for `NL` missing `the`

[sander-lameco]

What happened?

Description

When retrieving the Country Name using one of these methods:

{{ craft.app.getAddresses().countryRepository.get(address.countryCode).name }}
{% set storeCountries = craft.commerce.getStores().getCurrentStore().getCountriesList() %}

While on an english website, for NL it returns the name Netherlands instead of The Netherlands.

An article about the proper writing can be found here: https://www.jurisfluence.nl/en/netherlands/

I'm not sure if this can be fixed or is something we have to check in the code and depending on the locale and country code add the the ourselves at various places.

Steps to reproduce

1. Have an address in the Netherlands
2. Return the country name from the address.

Craft CMS version

5.8.17

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[linear]

CMS-1624

[lukeholder]

@sander-lameco The data comes from the commerceguys/addressing package, which in turn sourced the data from the Google address database.

I could consider making a PR to the commerceguys/addressing package, but I’m hesitant, as most other public sources — including the EU list — list it as "Netherlands" within lists in English.

As you can see in the source data (https://github.com/commerceguys/addressing/blob/main/resources/country/en-AU.json), each translation would need to know whether to prepend "The" in that language, and I don’t have the expertise to handle that consistently.

The \craft\services\Addresses::EVENT_DEFINE_ADDRESS_COUNTRIES event lets you modify the countries list based on the applicable locale. Would that work for you in the interim?

[sander-lameco]

Hi @lukeholder thanks for the reply. I'll have a look at the event else we could also just append it ourselves into the template by checking the "country code".