-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Summary
The current --auto-execute
flag in XMover's recommend command could be renamed to --confirm
for better user experience and clarity.
Current Implementation
In cratedb_toolkit/admin/xmover/tune/recommend.py
, the --auto-execute
flag is used to automatically proceed with executing shard relocation recommendations without manual confirmation.
Suggested Improvement
Rename --auto-execute
to --confirm
because:
--confirm
is more intuitive and commonly used in CLI tools- It better describes the action: confirming to proceed with the recommendations
- Reduces potential confusion about what "auto-execute" means in this context
Related
- PR: Admin/XMover: Add CrateDB shard analyzer and movement tool #523
- Comment: Admin/XMover: Add CrateDB shard analyzer and movement tool #523 (comment)
Implementation Notes
This change would affect:
- CLI argument definition in the recommend command
- Documentation and help text
- Any usage examples in docs
/cc @amotl
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request