don't look at package.metadata.cross when the package isn't part of the current workspace (#1623)

Emilgardis · web-flow · commit 107433fa9d71 · 2025-02-06T20:43:21.000Z
resolves #1619
diff --git a/.changes/1623.json b/.changes/1623.json
@@ -0,0 +1,4 @@
+{
+    "type": "fixed",
+    "description": "fixed an issue where cross would look for metadata.cross outside the workspace"
+  }
diff --git a/deny.toml b/deny.toml
@@ -9,10 +9,11 @@ targets = [
 
 [advisories]
 version = 2
-# FIXME: remove this if/when clap changes to is-terminal, atty is
-# patched, or we migrated to an MSRV of 1.66.0.
 ignore = [
+    # FIXME: remove this if/when clap changes to is-terminal, atty is
+    # patched, or we migrated to an MSRV of 1.66.0.
     "RUSTSEC-2021-0145",
+    "RUSTSEC-2024-0375"
 ]
 
 [bans]
diff --git a/src/lib.rs b/src/lib.rs
@@ -959,6 +959,7 @@ pub fn toml(metadata: &CargoMetadata, msg_info: &mut MessageInfo) -> Result<Cros
     for (package, package_metadata) in metadata
         .packages
         .iter()
+        .filter(|p| metadata.workspace_members.contains(&p.id))
         .filter_map(|p| Some((p.manifest_path.as_path(), p.metadata.as_deref()?)))
     {
         let package_metadata =

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +{
 +    "type": "fixed",
 +    "description": "fixed an issue where cross would look for metadata.cross outside the workspace"
 +  }
Original file line number	Diff line number	Diff line change
`@@ -959,6 +959,7 @@ pub fn toml(metadata: &CargoMetadata, msg_info: &mut MessageInfo) -> Result<Cros`
`959`	`959`	`for (package, package_metadata) in metadata`
`960`	`960`	`.packages`
`961`	`961`	`.iter()`
	`962`	`+ .filter(\|p\| metadata.workspace_members.contains(&p.id))`
`962`	`963`	`.filter_map(\|p\| Some((p.manifest_path.as_path(), p.metadata.as_deref()?)))`
`963`	`964`	`{`
`964`	`965`	`let package_metadata =`