Skip to content

Commit 74b84d1

Browse files
storulfgregkh
authored andcommitted
driver core: fw_devlink: Don't warn about sync_state() pending
Due to the wider deployment of the ->sync_state() support, for PM domains for example, we are receiving reports about the sync_state() pending message that is being logged in fw_devlink_dev_sync_state(). In particular as it's printed at the warning level, which is questionable. Even if it certainly is useful to know that the ->sync_state() condition could not be met, there may be nothing wrong with it. For example, a driver may be built as module and are still waiting to be initialized/probed. For this reason let's move to the info level for now. Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Reported-by: Sebin Francis <sebin.francis@ti.com> Reported-by: Diederik de Haas <didi.debian@cknow.org> Reported-by: Jon Hunter <jonathanh@nvidia.com> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Dhruva Gole <d-gole@ti.com> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> Reviewed-by: Kevin Hilman <khilman@baylibre.com> Acked-by: Saravana Kannan <saravanak@google.com> Reviewed-by: Sebin Francis <sebin.francis@ti.com> Tested-by: Sebin Francis <sebin.francis@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 3a86608 commit 74b84d1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/base/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1784,7 +1784,7 @@ static int fw_devlink_dev_sync_state(struct device *dev, void *data)
17841784
return 0;
17851785

17861786
if (fw_devlink_sync_state == FW_DEVLINK_SYNC_STATE_STRICT) {
1787-
dev_warn(sup, "sync_state() pending due to %s\n",
1787+
dev_info(sup, "sync_state() pending due to %s\n",
17881788
dev_name(link->consumer));
17891789
return 0;
17901790
}

0 commit comments

Comments
 (0)