Convert to i32

Author: curtisalexander

crates/readstat/src/cb.rs

@@ -58,17 +58,26 @@ pub extern "C" fn handle_metadata(
     .expect("Panics (returns None) on the out-of-range number of seconds (more than 262 000 years away from common era) and/or invalid nanosecond (2 seconds or more")
     .format("%Y-%m-%d %H:%M:%S")
     .to_string();
+
+    #[allow(clippy::useless_conversion)]
     let compression = match FromPrimitive::from_i32(unsafe {
         readstat_sys::readstat_get_compression(metadata)
+            .try_into()
+            .unwrap()
     }) {
         Some(t) => t,
         None => ReadStatCompress::None,
     };
-    let endianness =
-        match FromPrimitive::from_i32(unsafe { readstat_sys::readstat_get_endianness(metadata) }) {
-            Some(t) => t,
-            None => ReadStatEndian::None,
-        };
+
+    #[allow(clippy::useless_conversion)]
+    let endianness = match FromPrimitive::from_i32(unsafe {
+        readstat_sys::readstat_get_endianness(metadata)
+            .try_into()
+            .unwrap()
+    }) {
+        Some(t) => t,
+        None => ReadStatEndian::None,
+    };
 
     debug!("row_count is {}", rc);
     debug!("var_count is {}", vc);
@@ -130,15 +139,21 @@ pub extern "C" fn handle_variable(
     let m = unsafe { &mut *(ctx as *mut ReadStatMetadata) };
 
     // get variable metadata
+    #[allow(clippy::useless_conversion)]
     let var_type = match FromPrimitive::from_i32(unsafe {
         readstat_sys::readstat_variable_get_type(variable)
+            .try_into()
+            .unwrap()
     }) {
         Some(t) => t,
         None => ReadStatVarType::Unknown,
     };
 
+    #[allow(clippy::useless_conversion)]
     let var_type_class = match FromPrimitive::from_i32(unsafe {
         readstat_sys::readstat_variable_get_type_class(variable)
+            .try_into()
+            .unwrap()
     }) {
         Some(t) => t,
         None => ReadStatVarTypeClass::Numeric,

crates/readstat/src/rs_data.rs

@@ -340,7 +340,8 @@ impl ReadStatData {
             .set_row_offset(Some(self.chunk_row_start.try_into().unwrap()))?
             .parse_sas7bdat(ppath, ctx);
 
-        match FromPrimitive::from_i32(error) {
+        #[allow(clippy::useless_conversion)]
+        match FromPrimitive::from_i32(error.try_into().unwrap()) {
             Some(ReadStatError::READSTAT_OK) => Ok(()),
             Some(e) => Err(From::from(format!(
                 "Error when attempting to parse sas7bdat: {:#?}",

crates/readstat/src/rs_metadata.rs

@@ -141,7 +141,8 @@ impl ReadStatMetadata {
         }
         */
 
-        match FromPrimitive::from_i32(error) {
+        #[allow(clippy::useless_conversion)]
+        match FromPrimitive::from_i32(error.try_into().unwrap()) {
             Some(ReadStatError::READSTAT_OK) => {
                 // if successful, initialize schema
                 self.schema = self.initialize_schema();

crates/readstat/src/rs_parser.rs

@@ -31,7 +31,8 @@ impl ReadStatParser {
             &set_metadata_handler_error
         );
 
-        match FromPrimitive::from_i32(set_metadata_handler_error) {
+        #[allow(clippy::useless_conversion)]
+        match FromPrimitive::from_i32(set_metadata_handler_error.try_into().unwrap()) {
             Some(ReadStatError::READSTAT_OK) => Ok(self),
             Some(e) => Err(From::from(format!(
                 "Unable to set metdata handler: {:#?}",
@@ -57,7 +58,8 @@ impl ReadStatParser {
                     &set_row_limit_error
                 );
 
-                match FromPrimitive::from_i32(set_row_limit_error) {
+                #[allow(clippy::useless_conversion)]
+                match FromPrimitive::from_i32(set_row_limit_error.try_into().unwrap()) {
                     Some(ReadStatError::READSTAT_OK) => Ok(self),
                     Some(e) => Err(From::from(format!("Unable to set row limit: {:#?}", e))),
                     None => Err(From::from(
@@ -83,7 +85,8 @@ impl ReadStatParser {
                     &set_row_offset_error
                 );
 
-                match FromPrimitive::from_i32(set_row_offset_error) {
+                #[allow(clippy::useless_conversion)]
+                match FromPrimitive::from_i32(set_row_offset_error.try_into().unwrap()) {
                     Some(ReadStatError::READSTAT_OK) => Ok(self),
                     Some(e) => Err(From::from(format!("Unable to set row limit: {:#?}", e))),
                     None => Err(From::from(
@@ -107,7 +110,8 @@ impl ReadStatParser {
             &set_variable_handler_error
         );
 
-        match FromPrimitive::from_i32(set_variable_handler_error) {
+        #[allow(clippy::useless_conversion)]
+        match FromPrimitive::from_i32(set_variable_handler_error.try_into().unwrap()) {
             Some(ReadStatError::READSTAT_OK) => Ok(self),
             Some(e) => Err(From::from(format!(
                 "Unable to set variable handler: {:#?}",
@@ -131,7 +135,8 @@ impl ReadStatParser {
             &set_value_handler_error
         );
 
-        match FromPrimitive::from_i32(set_value_handler_error) {
+        #[allow(clippy::useless_conversion)]
+        match FromPrimitive::from_i32(set_value_handler_error.try_into().unwrap()) {
             Some(ReadStatError::READSTAT_OK) => Ok(self),
             Some(e) => Err(From::from(format!("Unable to set value handler: {:#?}", e))),
             None => Err(From::from(