Incompatibility with Microsoft.Azure.WebJobs.Extensions.OpenApi

[josbol]

At the moment, the in-processs 4.2.0 version is not compatible with Microsoft.Azure.WebJobs.Extensions.OpenApi 1.5.1. The reason being that apparently the functions registered by the OpenApi assembly do not have any function name attributes (at least, that's what it looks like when debugging).

In FunctionsAuthorizeBindingProvider.cs:

private void ProcessAuthorization(ParameterInfo info)
{
	MethodInfo methodInfo = (info.Member as MethodInfo) ?? throw new InvalidOperationException("Unable to bind authorization context for " + info.Name + ".");
	Type declaringType = methodInfo.DeclaringType;
	FunctionNameAttribute customAttribute = methodInfo.GetCustomAttribute<FunctionNameAttribute>();

        // customAttribute is null here in the case of the OpenApi functions.

	_options.RegisterFunctionAuthorizationAttributesMetadata<FunctionAuthorizeAttribute>(customAttribute.Name, declaringType, methodInfo);
}

Considering those endpoints are anonymous, just skipping processed item would do the trick I guess (didn't test this!)

The function in question is RenderOAuth2Redirect

[artmasa]

Hi @josbol, I don' t know if a follow.
Every function should have the FunctionName attribute. You are saying that other methods exist that also process bindings for HttpRequest parameters that are not functions?

Do you have a snippet?

[josbol]

DarkloopOpenApiConflictExample.zip

Hi @artmasa!

That's the weird thing, when shown in the functions list on startup, they do have names:

        RenderOAuth2Redirect: [GET] http://localhost:7071/api/oauth2-redirect.html

        RenderOpenApiDocument: [GET] http://localhost:7071/api/openapi/{version}.{extension}

        RenderSwaggerDocument: [GET] http://localhost:7071/api/swagger.{extension}

        RenderSwaggerUI: [GET] http://localhost:7071/api/swagger/ui

These functions are being injected by the Microsoft.Azure.WebJobs.Extensions.OpenApi nuget package (adding it to the project is enough)

I have created a simple example (attached to this message):

• Package Microsoft.Azure.WebJobs.Extensions.OpenApi 1.6.0 (this version was release yesterday, but it is not related to this issue)
• Package DarkLoop.Azure.Functions.Authorization.InProcess 4.2.0
• Decorates the example function with a FunctionAuthorize attribute
• No configuration (I tested it with and without configuring anything related to darkloop and the openapi extension, there doesn't seem to be any difference)

Just running the project will cause an exception for each injected function by the OpenAPI extension in FunctionsAuthorizeBindingProvider.cs:

...
private void ProcessAuthorization(ParameterInfo info)
{
	MethodInfo methodInfo = (info.Member as MethodInfo) ?? throw new InvalidOperationException("Unable to bind authorization context for " + info.Name + ".");
	Type declaringType = methodInfo.DeclaringType;
	FunctionNameAttribute customAttribute = methodInfo.GetCustomAttribute<FunctionNameAttribute>();

        // customAttribute is null here in the case of the OpenApi functions.

	_options.RegisterFunctionAuthorizationAttributesMetadata<FunctionAuthorizeAttribute>(customAttribute.Name, declaringType, methodInfo);
}

[artmasa]

I see, interesting. That makes sense.

Would you have some time to create the change to just return when the method is not decorated with FunctionNameAttribute?

[josbol]

I created a pullrequest #83