fix: avoid-unused-parameters now support abstract methods (#438)

Author: dkrutskikh

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 * Fix rule and metrics excludes for monorepos.
+* Improve static code diagnostics `avoid-unused-parameters`, `prefer-match-file-name`.
 
 ## 4.2.0
 

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unused_parameters/visitor.dart

@@ -13,6 +13,7 @@ class _Visitor extends RecursiveAstVisitor<void> {
     final parameters = node.parameters;
 
     if (parent is ClassDeclaration && parent.isAbstract ||
+        node.isAbstract ||
         node.externalKeyword != null ||
         (parameters == null || parameters.parameters.isEmpty)) {
       return;

test/analyzers/lint_analyzer/rules/rules_factory_test.dart

@@ -36,9 +36,11 @@ void main() {
         'avoid-wrapping-in-padding': <String, Object>{},
         'prefer-extracting-callbacks': <String, Object>{},
         'prefer-single-widget-per-file': <String, Object>{},
+        'avoid-ignoring-return-values': <String, Object>{},
       }).map((rule) => rule.id),
       equals([
         'always-remove-listener',
+        'avoid-ignoring-return-values',
         'avoid-late-keyword',
         'avoid-non-null-assertion',
         'avoid-preserve-whitespace-false',

test/analyzers/lint_analyzer/rules/rules_list/avoid_unused_parameters/avoid_unused_parameters_test.dart

@@ -36,10 +36,10 @@ void main() {
 
       RuleTestHelper.verifyIssues(
         issues: issues,
-        startOffsets: [142, 210, 369, 415, 661, 537, 739],
-        startLines: [8, 11, 21, 24, 35, 29, 41],
-        startColumns: [20, 40, 20, 20, 28, 38, 20],
-        endOffsets: [155, 229, 382, 433, 677, 550, 755],
+        startOffsets: [142, 210, 369, 415, 661, 537, 739, 867],
+        startLines: [8, 11, 21, 24, 35, 29, 41, 47],
+        startColumns: [20, 40, 20, 20, 28, 38, 20, 23],
+        endOffsets: [155, 229, 382, 433, 677, 550, 755, 880],
         locationTexts: [
           'String string',
           'String secondString',
@@ -48,6 +48,7 @@ void main() {
           'TestClass object',
           'String string',
           'TestClass object',
+          'String string',
         ],
         messages: [
           'Parameter is unused.',
@@ -57,6 +58,7 @@ void main() {
           'Parameter is unused.',
           'Parameter is unused.',
           'Parameter is unused.',
+          'Parameter is unused.',
         ],
       );
     });

test/analyzers/lint_analyzer/rules/rules_list/avoid_unused_parameters/examples/correct_example.dart

@@ -71,3 +71,15 @@ void sixthFunction(TestClass object) {
   final func = (TestClass object) => object.value;
   object.firstMethod('');
 }
+
+mixin AbstractMixin {
+  AbstractMixin copyWithLegs(List<Leg> legs);
+
+  String secondMethod(String string) {
+    return string;
+  }
+}
+
+class FavsListener extends Mock {
+  void call(Iterable<FavoriteStop> value);
+}

test/analyzers/lint_analyzer/rules/rules_list/avoid_unused_parameters/examples/incorrect_example.dart

@@ -41,3 +41,10 @@ void fifthFunction(TestClass object, String string) {
 void sixthFunction(TestClass object) {
   final func = (TestClass object) => object.value;
 }
+
+mixin AbstractMixin {
+  // LINT
+  String secondMethod(String string) {
+    return 'string';
+  }
+}