Skip to content

Commit 1b5103f

Browse files
authored
[cronet_http] Upgrade cronet-embedded dependency version to support 16 KB page sizes (#1824)
1 parent f701e93 commit 1b5103f

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed

.github/workflows/cronet.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ env:
2222

2323
jobs:
2424
verify:
25-
name: Format & Analyze & Test
25+
name: Format & Analyze & Test (${{ matrix.cronetHttpNoPlay == 'true' && 'without Google Play' || 'with Google Play'}})
2626
runs-on: ubuntu-cpu16-ram64
2727
timeout-minutes: 30
2828
strategy:
@@ -55,7 +55,7 @@ jobs:
5555
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
5656
sudo udevadm control --reload-rules
5757
sudo udevadm trigger --name-match=kvm
58-
- name: Run tests
58+
- name: Run tests (${{ matrix.cronetHttpNoPlay == 'true' && 'without Google Play' || 'with Google Play'}})
5959
uses: reactivecircus/android-emulator-runner@1dcd0090116d15e7c562f8db72807de5e036a4ed
6060
if: always() && steps.install.outcome == 'success'
6161
with:
@@ -70,7 +70,7 @@ jobs:
7070
# the tests that rely on Google Play services with the newest API
7171
# level (34 as of March 2025). The tests that don't rely on Google
7272
# Play serviecs can test the oldest supported API level.
73-
api-level: ${{ matrix.cronetHttpNoPlay == 'true' && '21' || '29' }}
73+
api-level: ${{ matrix.cronetHttpNoPlay == 'true' && '24' || '29' }}
7474
disable-animations: true
7575
arch: x86_64
7676
target: ${{ matrix.cronetHttpNoPlay == 'true' && 'default' || 'google_apis' }}

pkgs/cronet_http/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## 1.6.0-wip
2+
3+
* Upgrade the `cronet-embedded` dependency to `141.7340` version to
4+
support 16 KB page sizes. `cronet-embedded` has target SDK version of 24.
5+
* Change the minimum SDK version to 24.
6+
17
## 1.5.0
28

39
* Add the ability to abort requests.

pkgs/cronet_http/android/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ android {
4848
// - .github/workflows/cronet.yml
4949
// - pkgs/cronet_http/android/build.gradle
5050
// - pkgs/cronet_http/example/android/app/build.gradle
51-
minSdkVersion 21
51+
minSdkVersion 24
5252
}
5353

5454
defaultConfig {
@@ -64,7 +64,7 @@ android {
6464

6565
dependencies {
6666
if (dartDefines.cronetHttpNoPlay == 'true') {
67-
implementation 'org.chromium.net:cronet-embedded:119.6045.31'
67+
implementation 'org.chromium.net:cronet-embedded:141.7340.3'
6868
} else {
6969
implementation "com.google.android.gms:play-services-cronet:18.1.0"
7070
}

pkgs/cronet_http/example/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ android {
4646
// - .github/workflows/cronet.yml
4747
// - pkgs/cronet_http/android/build.gradle
4848
// - pkgs/cronet_http/example/android/app/build.gradle
49-
minSdkVersion 21
49+
minSdkVersion 24
5050
targetSdkVersion flutter.targetSdkVersion
5151
versionCode flutterVersionCode.toInteger()
5252
versionName flutterVersionName

pkgs/cronet_http/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: cronet_http
2-
version: 1.5.0
2+
version: 1.6.0-wip
33
description: >-
44
An Android Flutter plugin that provides access to the Cronet HTTP client.
55
repository: https://github.com/dart-lang/http/tree/master/pkgs/cronet_http

0 commit comments

Comments
 (0)