Skip to content

Commit 1ca19e2

Browse files
authored
Reduce log level of pub_worker proxy-related failures. (#8976)
1 parent 1af34d4 commit 1ca19e2

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

pkg/pub_worker/lib/src/analyze.dart

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,17 @@ Future<void> analyze(Payload payload) async {
8181
);
8282
}
8383

84+
void warnTaskError(Exception e, StackTrace st) {
85+
_log.warning(
86+
'Failed to process ${payload.package} / ${p.version}',
87+
e,
88+
st,
89+
);
90+
}
91+
8492
void shoutTaskError(Object e, StackTrace st) {
8593
_log.shout(
86-
'failed to process ${payload.package} / ${p.version}',
94+
'Failed to process ${payload.package} / ${p.version}',
8795
e,
8896
st,
8997
);
@@ -120,13 +128,17 @@ Future<void> analyze(Payload payload) async {
120128
late final map = e.bodyAsJson();
121129
late final error = map['error'];
122130
late final code = map['code'] ?? (error is Map ? error['code'] : null);
123-
if (e.status == 400 && code is String && code == 'TaskAborted') {
131+
if (e.status >= 500) {
132+
warnTaskError(e, st);
133+
} else if (e.status == 400 && code is String && code == 'TaskAborted') {
124134
warnTaskAborted(e, st);
125135
} else {
126136
shoutTaskError(e, st);
127137
}
128138
} on ApiResponseException catch (e, st) {
129-
if (e.status == 400 && e.code == 'TaskAborted') {
139+
if (e.status >= 500) {
140+
warnTaskError(e, st);
141+
} else if (e.status == 400 && e.code == 'TaskAborted') {
130142
warnTaskAborted(e, st);
131143
} else {
132144
shoutTaskError(e, st);

0 commit comments

Comments
 (0)