Skip to content

Commit f1aa489

Browse files
isoosisoos
authored
Remove unnecessary getLatestVersion call. (#8037)
1 parent 2e80d2f commit f1aa489

File tree

11 files changed

+36
-23
lines changed

11 files changed

+36
-23
lines changed

‎app/lib/task/handlers.dart‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import 'dart:io' show gzip;
33

44
import 'package:pub_dev/dartdoc/dartdoc_page.dart';
55
import 'package:pub_dev/dartdoc/models.dart';
6-
import 'package:pub_dev/package/backend.dart';
76
import 'package:pub_dev/shared/exceptions.dart';
87
import 'package:pub_dev/shared/handlers.dart';
98
import 'package:pub_dev/shared/redis_cache.dart';
@@ -93,13 +92,12 @@ Future<shelf.Response> handleDartDoc(
9392
DartDocSidebar.fromJson(dataJson as Map<String, dynamic>);
9493
return utf8.encode(sidebar.content);
9594
}
96-
final latestVersion = await packageBackend.getLatestVersion(package);
9795
final page = DartDocPage.fromJson(dataJson as Map<String, dynamic>);
9896
final html = page.render(DartDocPageOptions(
9997
package: package,
10098
version: version,
10199
urlSegment: resolvedDocUrlVersion.urlSegment,
102-
isLatestStable: version == latestVersion,
100+
isLatestStable: resolvedDocUrlVersion.isLatestStable,
103101
path: path,
104102
searchQueryParameter: searchQueryParameter,
105103
));

‎app/test/task/testdata/goldens/documentation/oxygen/2.0.0/index.html‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<!DOCTYPE html>
22
<html lang="en">
33
<head>
4+
<meta name="robots" content="noindex"/>
45
<script type="text/javascript" src="https://www.googletagmanager.com/gtm.js?id=GTM-MX6DBN9" async="async"></script>
56
<script type="text/javascript" src="/static/hash-%%etag%%/js/gtm.js"></script>
67
<meta charset="utf-8"/>
@@ -10,6 +11,7 @@
1011
<meta name="description" content="oxygen API docs, for the Dart programming language."/>
1112
<title>oxygen - Dart API docs</title>
1213
<link rel="canonical" href="https://pub.dev/documentation/oxygen/2.0.0/"/>
14+
<meta rel="alternate" href="/documentation/oxygen/latest/"/>
1315
<link rel="preconnect" href="https://fonts.gstatic.com"/>
1416
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Roboto+Mono:ital,wght@0,300;0,400;0,500;0,700;1,400&amp;display=swap"/>
1517
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:opsz,wght,FILL,GRAD@24,400,0,0"/>
@@ -26,7 +28,7 @@
2628
</a>
2729
<ol class="breadcrumbs gt-separated dark hidden-xs">
2830
<li>
29-
<a href="/packages/oxygen">oxygen package</a>
31+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
3032
</li>
3133
<li class="self-crumb">documentation</li>
3234
</ol>
@@ -68,7 +70,7 @@ <h2>Libraries</h2>
6870
</header>
6971
<ol id="sidebar-nav" class="breadcrumbs gt-separated dark hidden-l">
7072
<li>
71-
<a href="/packages/oxygen">oxygen package</a>
73+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
7274
</li>
7375
<li class="self-crumb">documentation</li>
7476
</ol>

‎app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/MainClass-class.html‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<!DOCTYPE html>
22
<html lang="en">
33
<head>
4+
<meta name="robots" content="noindex"/>
45
<script type="text/javascript" src="https://www.googletagmanager.com/gtm.js?id=GTM-MX6DBN9" async="async"></script>
56
<script type="text/javascript" src="/static/hash-%%etag%%/js/gtm.js"></script>
67
<meta charset="utf-8"/>
@@ -10,6 +11,7 @@
1011
<meta name="description" content="API docs for the MainClass class from the oxygen library, for the Dart programming language."/>
1112
<title>MainClass class - oxygen library - Dart API</title>
1213
<link rel="canonical" href="https://pub.dev/documentation/oxygen/2.0.0/oxygen/MainClass-class.html"/>
14+
<meta rel="alternate" href="/documentation/oxygen/latest/"/>
1315
<link rel="preconnect" href="https://fonts.gstatic.com"/>
1416
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Roboto+Mono:ital,wght@0,300;0,400;0,500;0,700;1,400&amp;display=swap"/>
1517
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:opsz,wght,FILL,GRAD@24,400,0,0"/>
@@ -26,7 +28,7 @@
2628
</a>
2729
<ol class="breadcrumbs gt-separated dark hidden-xs">
2830
<li>
29-
<a href="/packages/oxygen">oxygen package</a>
31+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
3032
</li>
3133
<li>
3234
<a href="../index.html">documentation</a>
@@ -235,7 +237,7 @@ <h2>Operators</h2>
235237
</header>
236238
<ol id="sidebar-nav" class="breadcrumbs gt-separated dark hidden-l">
237239
<li>
238-
<a href="/packages/oxygen">oxygen package</a>
240+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
239241
</li>
240242
<li>
241243
<a href="../index.html">documentation</a>

‎app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/MainClass/MainClass.html‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<meta name="description" content="API docs for the MainClass constructor from Class MainClass from the oxygen library, for the Dart programming language."/>
1212
<title>MainClass constructor - MainClass - oxygen library - Dart API</title>
1313
<link rel="canonical" href="https://pub.dev/documentation/oxygen/2.0.0/oxygen/MainClass/MainClass.html"/>
14+
<meta rel="alternate" href="/documentation/oxygen/latest/"/>
1415
<link rel="preconnect" href="https://fonts.gstatic.com"/>
1516
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Roboto+Mono:ital,wght@0,300;0,400;0,500;0,700;1,400&amp;display=swap"/>
1617
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:opsz,wght,FILL,GRAD@24,400,0,0"/>
@@ -27,7 +28,7 @@
2728
</a>
2829
<ol class="breadcrumbs gt-separated dark hidden-xs">
2930
<li>
30-
<a href="/packages/oxygen">oxygen package</a>
31+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
3132
</li>
3233
<li>
3334
<a href="../../index.html">documentation</a>
@@ -93,7 +94,7 @@ <h2>
9394
</header>
9495
<ol id="sidebar-nav" class="breadcrumbs gt-separated dark hidden-l">
9596
<li>
96-
<a href="/packages/oxygen">oxygen package</a>
97+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
9798
</li>
9899
<li>
99100
<a href="../../index.html">documentation</a>

‎app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/MainClass/text.html‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<meta name="description" content="API docs for the text property from the MainClass class, for the Dart programming language."/>
1212
<title>text property - MainClass class - oxygen library - Dart API</title>
1313
<link rel="canonical" href="https://pub.dev/documentation/oxygen/2.0.0/oxygen/MainClass/text.html"/>
14+
<meta rel="alternate" href="/documentation/oxygen/latest/"/>
1415
<link rel="preconnect" href="https://fonts.gstatic.com"/>
1516
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Roboto+Mono:ital,wght@0,300;0,400;0,500;0,700;1,400&amp;display=swap"/>
1617
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:opsz,wght,FILL,GRAD@24,400,0,0"/>
@@ -27,7 +28,7 @@
2728
</a>
2829
<ol class="breadcrumbs gt-separated dark hidden-xs">
2930
<li>
30-
<a href="/packages/oxygen">oxygen package</a>
31+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
3132
</li>
3233
<li>
3334
<a href="../../index.html">documentation</a>
@@ -84,7 +85,7 @@ <h2>
8485
</header>
8586
<ol id="sidebar-nav" class="breadcrumbs gt-separated dark hidden-l">
8687
<li>
87-
<a href="/packages/oxygen">oxygen package</a>
88+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
8889
</li>
8990
<li>
9091
<a href="../../index.html">documentation</a>

‎app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/MainClass/toLowerCase.html‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<meta name="description" content="API docs for the toLowerCase method from the MainClass class, for the Dart programming language."/>
1212
<title>toLowerCase method - MainClass class - oxygen library - Dart API</title>
1313
<link rel="canonical" href="https://pub.dev/documentation/oxygen/2.0.0/oxygen/MainClass/toLowerCase.html"/>
14+
<meta rel="alternate" href="/documentation/oxygen/latest/"/>
1415
<link rel="preconnect" href="https://fonts.gstatic.com"/>
1516
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Roboto+Mono:ital,wght@0,300;0,400;0,500;0,700;1,400&amp;display=swap"/>
1617
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:opsz,wght,FILL,GRAD@24,400,0,0"/>
@@ -27,7 +28,7 @@
2728
</a>
2829
<ol class="breadcrumbs gt-separated dark hidden-xs">
2930
<li>
30-
<a href="/packages/oxygen">oxygen package</a>
31+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
3132
</li>
3233
<li>
3334
<a href="../../index.html">documentation</a>
@@ -93,7 +94,7 @@ <h2>
9394
</header>
9495
<ol id="sidebar-nav" class="breadcrumbs gt-separated dark hidden-l">
9596
<li>
96-
<a href="/packages/oxygen">oxygen package</a>
97+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
9798
</li>
9899
<li>
99100
<a href="../../index.html">documentation</a>

‎app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/MainClass/toString.html‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<meta name="description" content="API docs for the toString method from the MainClass class, for the Dart programming language."/>
1212
<title>toString method - MainClass class - oxygen library - Dart API</title>
1313
<link rel="canonical" href="https://pub.dev/documentation/oxygen/2.0.0/oxygen/MainClass/toString.html"/>
14+
<meta rel="alternate" href="/documentation/oxygen/latest/"/>
1415
<link rel="preconnect" href="https://fonts.gstatic.com"/>
1516
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Roboto+Mono:ital,wght@0,300;0,400;0,500;0,700;1,400&amp;display=swap"/>
1617
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:opsz,wght,FILL,GRAD@24,400,0,0"/>
@@ -27,7 +28,7 @@
2728
</a>
2829
<ol class="breadcrumbs gt-separated dark hidden-xs">
2930
<li>
30-
<a href="/packages/oxygen">oxygen package</a>
31+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
3132
</li>
3233
<li>
3334
<a href="../../index.html">documentation</a>
@@ -112,7 +113,7 @@ <h2>
112113
</header>
113114
<ol id="sidebar-nav" class="breadcrumbs gt-separated dark hidden-l">
114115
<li>
115-
<a href="/packages/oxygen">oxygen package</a>
116+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
116117
</li>
117118
<li>
118119
<a href="../../index.html">documentation</a>

‎app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/TypeEnum.html‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<!DOCTYPE html>
22
<html lang="en">
33
<head>
4+
<meta name="robots" content="noindex"/>
45
<script type="text/javascript" src="https://www.googletagmanager.com/gtm.js?id=GTM-MX6DBN9" async="async"></script>
56
<script type="text/javascript" src="/static/hash-%%etag%%/js/gtm.js"></script>
67
<meta charset="utf-8"/>
@@ -10,6 +11,7 @@
1011
<meta name="description" content="API docs for the TypeEnum enum from the oxygen library, for the Dart programming language."/>
1112
<title>TypeEnum enum - oxygen library - Dart API</title>
1213
<link rel="canonical" href="https://pub.dev/documentation/oxygen/2.0.0/oxygen/TypeEnum.html"/>
14+
<meta rel="alternate" href="/documentation/oxygen/latest/"/>
1315
<link rel="preconnect" href="https://fonts.gstatic.com"/>
1416
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Roboto+Mono:ital,wght@0,300;0,400;0,500;0,700;1,400&amp;display=swap"/>
1517
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:opsz,wght,FILL,GRAD@24,400,0,0"/>
@@ -26,7 +28,7 @@
2628
</a>
2729
<ol class="breadcrumbs gt-separated dark hidden-xs">
2830
<li>
29-
<a href="/packages/oxygen">oxygen package</a>
31+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
3032
</li>
3133
<li>
3234
<a href="../index.html">documentation</a>
@@ -265,7 +267,7 @@ <h2>Constants</h2>
265267
</header>
266268
<ol id="sidebar-nav" class="breadcrumbs gt-separated dark hidden-l">
267269
<li>
268-
<a href="/packages/oxygen">oxygen package</a>
270+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
269271
</li>
270272
<li>
271273
<a href="../index.html">documentation</a>

‎app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/TypeEnum/values-constant.html‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<meta name="description" content="API docs for the values constant from the TypeEnum enum, for the Dart programming language."/>
1212
<title>values constant - TypeEnum enum - oxygen library - Dart API</title>
1313
<link rel="canonical" href="https://pub.dev/documentation/oxygen/2.0.0/oxygen/TypeEnum/values-constant.html"/>
14+
<meta rel="alternate" href="/documentation/oxygen/latest/"/>
1415
<link rel="preconnect" href="https://fonts.gstatic.com"/>
1516
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Roboto+Mono:ital,wght@0,300;0,400;0,500;0,700;1,400&amp;display=swap"/>
1617
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:opsz,wght,FILL,GRAD@24,400,0,0"/>
@@ -27,7 +28,7 @@
2728
</a>
2829
<ol class="breadcrumbs gt-separated dark hidden-xs">
2930
<li>
30-
<a href="/packages/oxygen">oxygen package</a>
31+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
3132
</li>
3233
<li>
3334
<a href="../../index.html">documentation</a>
@@ -85,7 +86,7 @@ <h1>
8586
</header>
8687
<ol id="sidebar-nav" class="breadcrumbs gt-separated dark hidden-l">
8788
<li>
88-
<a href="/packages/oxygen">oxygen package</a>
89+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
8990
</li>
9091
<li>
9192
<a href="../../index.html">documentation</a>

‎app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/main.html‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<!DOCTYPE html>
22
<html lang="en">
33
<head>
4+
<meta name="robots" content="noindex"/>
45
<script type="text/javascript" src="https://www.googletagmanager.com/gtm.js?id=GTM-MX6DBN9" async="async"></script>
56
<script type="text/javascript" src="/static/hash-%%etag%%/js/gtm.js"></script>
67
<meta charset="utf-8"/>
@@ -10,6 +11,7 @@
1011
<meta name="description" content="API docs for the main function from the oxygen library, for the Dart programming language."/>
1112
<title>main function - oxygen library - Dart API</title>
1213
<link rel="canonical" href="https://pub.dev/documentation/oxygen/2.0.0/oxygen/main.html"/>
14+
<meta rel="alternate" href="/documentation/oxygen/latest/"/>
1315
<link rel="preconnect" href="https://fonts.gstatic.com"/>
1416
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Roboto+Mono:ital,wght@0,300;0,400;0,500;0,700;1,400&amp;display=swap"/>
1517
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:opsz,wght,FILL,GRAD@24,400,0,0"/>
@@ -26,7 +28,7 @@
2628
</a>
2729
<ol class="breadcrumbs gt-separated dark hidden-xs">
2830
<li>
29-
<a href="/packages/oxygen">oxygen package</a>
31+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
3032
</li>
3133
<li>
3234
<a href="../index.html">documentation</a>
@@ -80,7 +82,7 @@ <h2>
8082
</header>
8183
<ol id="sidebar-nav" class="breadcrumbs gt-separated dark hidden-l">
8284
<li>
83-
<a href="/packages/oxygen">oxygen package</a>
85+
<a href="/packages/oxygen/versions/2.0.0">oxygen package</a>
8486
</li>
8587
<li>
8688
<a href="../index.html">documentation</a>

0 commit comments

Comments
 (0)