From fa8d7f56a6071888a3ade18f25af8af09f804279 Mon Sep 17 00:00:00 2001 From: Istvan Soos Date: Mon, 27 Jan 2025 09:39:23 +0100 Subject: [PATCH 1/2] Add topics-tag class on infobox topic links. --- app/lib/frontend/templates/views/pkg/info_box.dart | 5 +++-- app/test/frontend/golden/pkg_activity_log_page.html | 4 ++-- app/test/frontend/golden/pkg_admin_page.html | 4 ++-- app/test/frontend/golden/pkg_changelog_page.html | 4 ++-- app/test/frontend/golden/pkg_example_page.html | 4 ++-- app/test/frontend/golden/pkg_install_page.html | 4 ++-- app/test/frontend/golden/pkg_score_page.html | 4 ++-- .../frontend/golden/pkg_score_page_with_downloads_chart.html | 4 ++-- app/test/frontend/golden/pkg_show_page.html | 4 ++-- app/test/frontend/golden/pkg_show_page_discontinued.html | 4 ++-- app/test/frontend/golden/pkg_show_page_flutter_plugin.html | 4 ++-- app/test/frontend/golden/pkg_show_page_publisher.html | 4 ++-- app/test/frontend/golden/pkg_show_page_retracted.html | 4 ++-- .../pkg_show_page_retracted_non_retracted_version.html | 4 ++-- app/test/frontend/golden/pkg_show_version_page.html | 4 ++-- app/test/frontend/golden/pkg_versions_page.html | 4 ++-- app/test/task/testdata/goldens/packages/oxygen.html | 4 ++-- .../task/testdata/goldens/packages/oxygen/changelog.html | 4 ++-- app/test/task/testdata/goldens/packages/oxygen/example.html | 4 ++-- app/test/task/testdata/goldens/packages/oxygen/install.html | 4 ++-- app/test/task/testdata/goldens/packages/oxygen/license.html | 4 ++-- app/test/task/testdata/goldens/packages/oxygen/score.html | 4 ++-- app/test/task/testdata/goldens/packages/oxygen/versions.html | 4 ++-- .../testdata/goldens/packages/oxygen/versions/1.0.0.html | 4 ++-- .../goldens/packages/oxygen/versions/1.0.0/changelog.html | 4 ++-- .../goldens/packages/oxygen/versions/1.0.0/example.html | 4 ++-- .../goldens/packages/oxygen/versions/1.0.0/install.html | 4 ++-- .../goldens/packages/oxygen/versions/1.0.0/license.html | 4 ++-- .../goldens/packages/oxygen/versions/1.0.0/score.html | 4 ++-- .../testdata/goldens/packages/oxygen/versions/2.0.0.html | 4 ++-- 30 files changed, 61 insertions(+), 60 deletions(-) diff --git a/app/lib/frontend/templates/views/pkg/info_box.dart b/app/lib/frontend/templates/views/pkg/info_box.dart index 09f62268d..40b0f285b 100644 --- a/app/lib/frontend/templates/views/pkg/info_box.dart +++ b/app/lib/frontend/templates/views/pkg/info_box.dart @@ -54,7 +54,7 @@ d.Node packageInfoBoxNode({ ); } final dependencies = _dependencyListNode(version.pubspec?.dependencies); - final topics = _topicstNode(version.pubspec?.canonicalizedTopics); + final topics = _topicsNode(version.pubspec?.canonicalizedTopics); final screenshots = data.scoreCard.panaReport?.screenshots; String? thumbnailUrl; @@ -206,7 +206,7 @@ d.Node? _licenseNode({ ]); } -d.Node? _topicstNode(List? topics) { +d.Node? _topicsNode(List? topics) { if (topics == null || topics.isEmpty) return null; final nodes = []; @@ -217,6 +217,7 @@ d.Node? _topicstNode(List? topics) { final ct = canonicalTopics.asMap[topic]; final description = ct?.description; final node = d.a( + classes: ['topics-tag'], href: urls.searchUrl(q: 'topic:$topic'), text: '#$topic', title: description, diff --git a/app/test/frontend/golden/pkg_activity_log_page.html b/app/test/frontend/golden/pkg_activity_log_page.html index 3b668628a..dfb405ef9 100644 --- a/app/test/frontend/golden/pkg_activity_log_page.html +++ b/app/test/frontend/golden/pkg_activity_log_page.html @@ -396,7 +396,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -472,7 +472,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_admin_page.html b/app/test/frontend/golden/pkg_admin_page.html index 5d471eb90..206434041 100644 --- a/app/test/frontend/golden/pkg_admin_page.html +++ b/app/test/frontend/golden/pkg_admin_page.html @@ -681,7 +681,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -757,7 +757,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_changelog_page.html b/app/test/frontend/golden/pkg_changelog_page.html index 653b4b21c..6a4cc53ad 100644 --- a/app/test/frontend/golden/pkg_changelog_page.html +++ b/app/test/frontend/golden/pkg_changelog_page.html @@ -266,7 +266,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -343,7 +343,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_example_page.html b/app/test/frontend/golden/pkg_example_page.html index 6a5492e7d..1fb836318 100644 --- a/app/test/frontend/golden/pkg_example_page.html +++ b/app/test/frontend/golden/pkg_example_page.html @@ -263,7 +263,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -340,7 +340,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_install_page.html b/app/test/frontend/golden/pkg_install_page.html index dc206f8ca..a54056c78 100644 --- a/app/test/frontend/golden/pkg_install_page.html +++ b/app/test/frontend/golden/pkg_install_page.html @@ -289,7 +289,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -366,7 +366,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_score_page.html b/app/test/frontend/golden/pkg_score_page.html index 6e6fca458..b1b301428 100644 --- a/app/test/frontend/golden/pkg_score_page.html +++ b/app/test/frontend/golden/pkg_score_page.html @@ -351,7 +351,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -428,7 +428,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html b/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html index 6e6fca458..b1b301428 100644 --- a/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html +++ b/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html @@ -351,7 +351,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -428,7 +428,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_show_page.html b/app/test/frontend/golden/pkg_show_page.html index 95c6828ba..381ead32e 100644 --- a/app/test/frontend/golden/pkg_show_page.html +++ b/app/test/frontend/golden/pkg_show_page.html @@ -266,7 +266,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -343,7 +343,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_show_page_discontinued.html b/app/test/frontend/golden/pkg_show_page_discontinued.html index 4be67941d..db4d74ee6 100644 --- a/app/test/frontend/golden/pkg_show_page_discontinued.html +++ b/app/test/frontend/golden/pkg_show_page_discontinued.html @@ -257,7 +257,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -332,7 +332,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_show_page_flutter_plugin.html b/app/test/frontend/golden/pkg_show_page_flutter_plugin.html index fbf7bf2bd..d5542b475 100644 --- a/app/test/frontend/golden/pkg_show_page_flutter_plugin.html +++ b/app/test/frontend/golden/pkg_show_page_flutter_plugin.html @@ -255,7 +255,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -336,7 +336,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_show_page_publisher.html b/app/test/frontend/golden/pkg_show_page_publisher.html index 73b3610fd..5634d37cb 100644 --- a/app/test/frontend/golden/pkg_show_page_publisher.html +++ b/app/test/frontend/golden/pkg_show_page_publisher.html @@ -257,7 +257,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -329,7 +329,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_show_page_retracted.html b/app/test/frontend/golden/pkg_show_page_retracted.html index 6c93b794b..6ad3e1da1 100644 --- a/app/test/frontend/golden/pkg_show_page_retracted.html +++ b/app/test/frontend/golden/pkg_show_page_retracted.html @@ -242,7 +242,7 @@

Topics

- #chemical-element + #chemical-element

Funding

@@ -314,7 +314,7 @@

Topics

- #chemical-element + #chemical-element

Funding

diff --git a/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html b/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html index 9ea471a23..4259597f4 100644 --- a/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html +++ b/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html @@ -248,7 +248,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -323,7 +323,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_show_version_page.html b/app/test/frontend/golden/pkg_show_version_page.html index 008985179..b7a780fae 100644 --- a/app/test/frontend/golden/pkg_show_version_page.html +++ b/app/test/frontend/golden/pkg_show_version_page.html @@ -260,7 +260,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -337,7 +337,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/frontend/golden/pkg_versions_page.html b/app/test/frontend/golden/pkg_versions_page.html index fa8207328..6a1330479 100644 --- a/app/test/frontend/golden/pkg_versions_page.html +++ b/app/test/frontend/golden/pkg_versions_page.html @@ -373,7 +373,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -450,7 +450,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen.html b/app/test/task/testdata/goldens/packages/oxygen.html index 543394fb7..21963a32d 100644 --- a/app/test/task/testdata/goldens/packages/oxygen.html +++ b/app/test/task/testdata/goldens/packages/oxygen.html @@ -254,7 +254,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -333,7 +333,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/changelog.html b/app/test/task/testdata/goldens/packages/oxygen/changelog.html index 4fe0d7ad5..c3204a9c5 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/changelog.html +++ b/app/test/task/testdata/goldens/packages/oxygen/changelog.html @@ -260,7 +260,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -339,7 +339,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/example.html b/app/test/task/testdata/goldens/packages/oxygen/example.html index abcdfab3d..60b20d882 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/example.html +++ b/app/test/task/testdata/goldens/packages/oxygen/example.html @@ -255,7 +255,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -334,7 +334,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/install.html b/app/test/task/testdata/goldens/packages/oxygen/install.html index 27c90cb87..c5e78da25 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/install.html +++ b/app/test/task/testdata/goldens/packages/oxygen/install.html @@ -283,7 +283,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -362,7 +362,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/license.html b/app/test/task/testdata/goldens/packages/oxygen/license.html index 16d73b1ae..941278650 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/license.html +++ b/app/test/task/testdata/goldens/packages/oxygen/license.html @@ -256,7 +256,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -335,7 +335,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/score.html b/app/test/task/testdata/goldens/packages/oxygen/score.html index df4a695e7..ad37a7fc7 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/score.html +++ b/app/test/task/testdata/goldens/packages/oxygen/score.html @@ -564,7 +564,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -643,7 +643,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions.html b/app/test/task/testdata/goldens/packages/oxygen/versions.html index d1ce1700d..e3790873c 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions.html @@ -316,7 +316,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -395,7 +395,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0.html b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0.html index a6bf34ca3..dfde73a8a 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0.html @@ -258,7 +258,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -337,7 +337,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/changelog.html b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/changelog.html index 349766104..21338c8db 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/changelog.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/changelog.html @@ -264,7 +264,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -343,7 +343,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/example.html b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/example.html index 2848b86b8..6c7ed7c80 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/example.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/example.html @@ -259,7 +259,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -338,7 +338,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/install.html b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/install.html index 459e6b4f5..d29c9cbf4 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/install.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/install.html @@ -287,7 +287,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -366,7 +366,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/license.html b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/license.html index c7ab1db2c..d2c77eba9 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/license.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/license.html @@ -260,7 +260,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -339,7 +339,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/score.html b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/score.html index e45c812dc..66ca9eed5 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/score.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/score.html @@ -568,7 +568,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -647,7 +647,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

diff --git a/app/test/task/testdata/goldens/packages/oxygen/versions/2.0.0.html b/app/test/task/testdata/goldens/packages/oxygen/versions/2.0.0.html index 543394fb7..21963a32d 100644 --- a/app/test/task/testdata/goldens/packages/oxygen/versions/2.0.0.html +++ b/app/test/task/testdata/goldens/packages/oxygen/versions/2.0.0.html @@ -254,7 +254,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

@@ -333,7 +333,7 @@

Topics

- #chemical-element + #chemical-element

Documentation

From 01ac81fda52baefac8c23a21369c6b055370fa83 Mon Sep 17 00:00:00 2001 From: Istvan Soos Date: Mon, 27 Jan 2025 10:33:59 +0100 Subject: [PATCH 2/2] Bump time threshold in flutter test. --- pkg/_pub_shared/test/utils/flutter_archive_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/_pub_shared/test/utils/flutter_archive_test.dart b/pkg/_pub_shared/test/utils/flutter_archive_test.dart index b2122b872..978f9a32d 100644 --- a/pkg/_pub_shared/test/utils/flutter_archive_test.dart +++ b/pkg/_pub_shared/test/utils/flutter_archive_test.dart @@ -17,7 +17,7 @@ void main() { ); expect( DateTime.now().difference(archive.latestBeta!.releaseDate!).inDays, - lessThan(45), + lessThan(60), ); expect(archive.latestStable?.semanticDartSdkVersion, isNotNull); expect(archive.latestBeta?.semanticDartSdkVersion, isNotNull);