DAS: PluginCodeActionsProducer.driver can be private, benefit from promotion

Change-Id: I79d37becada793349f7330de44f1fdb19408b312
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/450141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>

Author: srawlins

pkg/analysis_server/lib/src/lsp/handlers/code_actions/plugins.dart

@@ -16,7 +16,7 @@ import 'package:collection/collection.dart';
 
 /// Produces [CodeActionLiteral]s from Plugin fixes and assists.
 class PluginCodeActionsProducer extends AbstractCodeActionsProducer {
-  final AnalysisDriver? driver;
+  final AnalysisDriver? _driver;
 
   PluginCodeActionsProducer(
     super.server,
@@ -31,7 +31,7 @@ class PluginCodeActionsProducer extends AbstractCodeActionsProducer {
     required super.allowCommands,
     required super.analysisOptions,
     required super.allowSnippets,
-  }) : driver = server.getAnalysisDriver(file.path);
+  }) : _driver = server.getAnalysisDriver(file.path);
 
   @override
   String get name => 'PluginActionsComputer';
@@ -149,12 +149,14 @@ class PluginCodeActionsProducer extends AbstractCodeActionsProducer {
   Future<List<plugin.Response>> _sendPluginRequest(
     plugin.RequestParams requestParams,
   ) async {
-    var driver = this.driver;
-    if (driver == null) {
-      return [];
+    if (_driver == null) {
+      return const [];
     }
 
-    var pluginFutures = server.broadcastRequestToPlugins(requestParams, driver);
+    var pluginFutures = server.broadcastRequestToPlugins(
+      requestParams,
+      _driver,
+    );
 
     return waitForResponses(pluginFutures, requestParameters: requestParams);
   }