Skip to content

Commit e4fd90f

Browse files
scheglovCommit Queue
authored andcommitted
CQ. Update configuration.withExcludedGlobs before _assertWorkspaceCollectionText().
This is what we do in other tests, update configuration directly. Change-Id: Ife684fd4204acb43615c9e1a7cc27ae839255f5a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/466463 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Paul Berry <paulberry@google.com>
1 parent f04ff04 commit e4fd90f

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

pkg/analyzer/test/src/dart/analysis/analysis_context_collection_test.dart

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -671,10 +671,8 @@ analyzer:
671671
// - foo/** in /home/test
672672
// - foo in /home/test
673673
// But at least that's it.
674-
_assertWorkspaceCollectionText(
675-
workspaceRootPath,
676-
withExcludedGlobs: true,
677-
r'''
674+
configuration.withExcludedGlobs = true;
675+
_assertWorkspaceCollectionText(workspaceRootPath, r'''
678676
contexts
679677
/home/test
680678
packagesFile: /home/test/.dart_tool/package_config.json
@@ -711,8 +709,7 @@ workspaces
711709
pubPackages
712710
workspacePackage_0_0: PubPackage
713711
root: /home/test
714-
''',
715-
);
712+
''');
716713
}
717714

718715
test_packageConfigWorkspace_multipleAnalysisOptions_outerExclude() async {
@@ -1708,15 +1705,13 @@ workspaces
17081705
void _assertWorkspaceCollectionText(
17091706
String workspaceRootPath,
17101707
String expected, {
1711-
bool withExcludedGlobs = false,
17121708
File? optionsFile,
17131709
void Function({required AnalysisOptionsImpl analysisOptions})?
17141710
updateAnalysisOptions,
17151711
}) {
17161712
if (optionsFile != null) {
17171713
expect(optionsFile.exists, isTrue);
17181714
}
1719-
configuration.withExcludedGlobs = withExcludedGlobs;
17201715
var collection = AnalysisContextCollectionImpl(
17211716
resourceProvider: resourceProvider,
17221717
sdkPath: sdkRoot.path,

0 commit comments

Comments
 (0)