Feature Request: When restore target file is not specified, restore the latest backup by timestamp

[shaunakv1]

This will make the automation of restores specifically in a "mirroring" scenario where two databases just need to be kept in sync a lot simpler.

Idea would be that if restore command is called without a specified dump file, then use the list API of s3 to find the newest backup file by the timestamp using the file pattern configured ( or default) and use the newest dump to restore the database.

It could be beneficial to optionally enable this behaviour with a config or environment variable like "AUTO_RESTORE_LATEST" which defaults to false.

[deitch]

OK, it is interesting. I wouldn't do it without an enabling flag, as we don't want to surprise anyone.

I think most of the logic for listing in various target types - s3, smb, file, etc. - is already there from pruning logic.

Put together a PR for it?

[ZetaMap]

Assuming all backup are in the same directory/target, it's possible to make an additional config file that store the file name of the last backup. Like that, we can also know the file name of the last created backup, when scripting these things.

For me, this would be very useful.
Because when i create a backup, idk it's name. So i need to make an additional function to determine the latest backup, and it's very annoying to have to do that.

[deitch]

Assuming all backup are in the same directory/target, it's possible to make an additional config file that store the file name of the last backup. Like that, we can also know the file name of the last created backup, when scripting these things.

You mean to store it in a metadata file in the same target? It is an interesting idea. You cannot 100% rely on it being a single directory. In general, it is, but the custom pattern filename lets you do use variables, so someone might use a directory structure. I can see that growing in the future and would not want to block it out. Still, if that metadata file ever became necessary, it is possible to create a config file/flag/env var pattern for it, too.

The question is, is it necessary? The targets all support some form of filename listing with metadata such as creation (or last modification time): smb, s3, directory. I recently was involved with a project that had to support Azure blob container, I wouldn't mind adding that in the future, but that also supports retrieving metadata.

So i need to make an additional function to determine the latest backup, and it's very annoying to have to do that.

And if you can get the most recent one by timestamp?

I definitely am open to a PR for this.

[ZetaMap]

And if you can get the most recent one by timestamp?

Yes i can:

latest_backup="$(basename $(ls ./mysql-backup_files/db_backup_* | sort -V | tail -n 1))"

But I need to do this… and like any developer, I'm lazy, and I don't want to do this. I want the tool to do it for me =).

[deitch]

I can see that.

Currently, iyou run mysql-backup restore file:///foo/bar.tgz or restore s3://bucket/path/to/file.tgz.

What option would you add? restore file://foo/ --restore-latest or similar? Normally, if you just did file://foo/ it would complain that it cannot find an actual file like that.

[ZetaMap]

Yes an option like that, --latest, that's use --filename-pattern to determine latest backup file. So you'll need to add --filename-pattern and --safe-characters options to the restore command and specify that'll only be used with --latest option.