Commit 0dfe0f4
authored
Add functionality for export of latency logs via telemetry (#608)
* added functionality for export of failure logs
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* changed logger.error to logger.debug in exc.py
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* Fix telemetry loss during Python shutdown
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* unit tests for export_failure_log
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* try-catch blocks to make telemetry failures non-blocking for connector operations
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed redundant try/catch blocks, added try/catch block to initialize and get telemetry client
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* skip null fields in telemetry request
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed dup import, renamed func, changed a filter_null_values to lamda
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed unnecassary class variable and a redundant try/except block
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* public functions defined at interface level
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* changed export_event and flush to private functions
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* formatting
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* changed connection_uuid to thread local in thrift backend
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* made errors more specific
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* revert change to connection_uuid
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* reverting change in close in telemetry client
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* JsonSerializableMixin
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* isdataclass check in JsonSerializableMixin
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* convert TelemetryClientFactory to module-level functions, replace NoopTelemetryClient class with NOOP_TELEMETRY_CLIENT singleton, updated tests accordingly
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* renamed connection_uuid as session_id_hex
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* added NotImplementedError to abstract class, added unit tests
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* formatting
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* added PEP-249 link, changed NoopTelemetryClient implementation
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed unused import
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* made telemetry client close a module-level function
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* unit tests verbose
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* debug logs in unit tests
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* debug logs in unit tests
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed ABC from mixin, added try/catch block around executor shutdown
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* checking stuff
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* finding out
* finding out more
* more more finding out more nice
* locks are useless anyways
* haha
* normal
* := looks like walrus horizontally
* one more
* walrus again
* old stuff without walrus seems to fail
* manually do the walrussing
* change 3.13t, v2
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* formatting, added walrus
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* formatting
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed walrus, removed test before stalling test
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* changed order of stalling test
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed debugging, added TelemetryClientFactory
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* remove more debugging
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* latency logs funcitionality
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* fixed type of return value in get_session_id_hex() in thrift backend
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* debug on TelemetryClientFactory lock
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* formatting
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* type notation for _waiters
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* called connection.close() in test_arraysize_buffer_size_passthrough
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* run all unit tests
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* more debugging
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed the connection.close() from that test, put debug statement before and after TelemetryClientFactory lock
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* more debug
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* more more more
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* why
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* whywhy
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* thread name
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* added teardown to all tests except finalizer test (gc collect)
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* added the get_attribute functions to the classes
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed tearDown, added connection.close() to first test
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* finally
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* remove debugging
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* added test for export_latency_log, made mock of thrift backend with retry policy
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* added multi threaded tests
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* formatting
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* added TelemetryExtractor, removed multithreaded tests
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* formatting
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* fixes in test
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* fix in telemetry extractor
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* added doc strings to latency_logger, abstracted export_telemetry_log
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* statement type, unit test fix
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* unit test fix
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* statement type changes
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* test_fetches fix
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* added mocks to resolve the errors caused by log_latency decorator in tests
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed function in test_fetches cuz it is only used once
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* added _safe_call which returns None in case of errors in the get functions
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed the changes in test_client and test_fetches
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed the changes in test_fetches
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* test_telemetry
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
* removed test
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
---------
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>1 parent 6748c2c commit 0dfe0f4
File tree
4 files changed
+475
-440
lines changed- src/databricks/sql
- telemetry
- tests/unit
4 files changed
+475
-440
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
| 65 | + | |
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
| |||
745 | 746 | | |
746 | 747 | | |
747 | 748 | | |
| 749 | + | |
748 | 750 | | |
749 | 751 | | |
750 | 752 | | |
| |||
784 | 786 | | |
785 | 787 | | |
786 | 788 | | |
| 789 | + | |
787 | 790 | | |
788 | 791 | | |
789 | 792 | | |
| |||
811 | 814 | | |
812 | 815 | | |
813 | 816 | | |
| 817 | + | |
814 | 818 | | |
815 | 819 | | |
816 | 820 | | |
| |||
824 | 828 | | |
825 | 829 | | |
826 | 830 | | |
| 831 | + | |
827 | 832 | | |
828 | 833 | | |
829 | 834 | | |
| |||
914 | 919 | | |
915 | 920 | | |
916 | 921 | | |
| 922 | + | |
917 | 923 | | |
918 | 924 | | |
919 | 925 | | |
| |||
1039 | 1045 | | |
1040 | 1046 | | |
1041 | 1047 | | |
| 1048 | + | |
1042 | 1049 | | |
1043 | 1050 | | |
1044 | 1051 | | |
| |||
1062 | 1069 | | |
1063 | 1070 | | |
1064 | 1071 | | |
| 1072 | + | |
1065 | 1073 | | |
1066 | 1074 | | |
1067 | 1075 | | |
| |||
1090 | 1098 | | |
1091 | 1099 | | |
1092 | 1100 | | |
| 1101 | + | |
1093 | 1102 | | |
1094 | 1103 | | |
1095 | 1104 | | |
| |||
1125 | 1134 | | |
1126 | 1135 | | |
1127 | 1136 | | |
| 1137 | + | |
1128 | 1138 | | |
1129 | 1139 | | |
1130 | 1140 | | |
| |||
1379 | 1389 | | |
1380 | 1390 | | |
1381 | 1391 | | |
| 1392 | + | |
1382 | 1393 | | |
1383 | 1394 | | |
1384 | 1395 | | |
| |||
1391 | 1402 | | |
1392 | 1403 | | |
1393 | 1404 | | |
| 1405 | + | |
1394 | 1406 | | |
1395 | 1407 | | |
1396 | 1408 | | |
| |||
1433 | 1445 | | |
1434 | 1446 | | |
1435 | 1447 | | |
| 1448 | + | |
1436 | 1449 | | |
1437 | 1450 | | |
1438 | 1451 | | |
| |||
1475 | 1488 | | |
1476 | 1489 | | |
1477 | 1490 | | |
| 1491 | + | |
1478 | 1492 | | |
1479 | 1493 | | |
1480 | 1494 | | |
| |||
1500 | 1514 | | |
1501 | 1515 | | |
1502 | 1516 | | |
| 1517 | + | |
1503 | 1518 | | |
1504 | 1519 | | |
1505 | 1520 | | |
| |||
1526 | 1541 | | |
1527 | 1542 | | |
1528 | 1543 | | |
| 1544 | + | |
1529 | 1545 | | |
1530 | 1546 | | |
1531 | 1547 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
0 commit comments