removed walrus, removed test before stalling test

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

Author: saishreeeee

src/databricks/sql/telemetry/telemetry_client.py

@@ -396,9 +396,9 @@ def close_telemetry_client(session_id_hex):
     """Remove the telemetry client for a specific connection"""
     global _initialized, _executor
     with _lock:
-        if (telemetry_client := _clients.pop(session_id_hex, None)) is not None:
-            # if session_id_hex in _clients:
-            #     telemetry_client = _clients.pop(session_id_hex)
+        # if (telemetry_client := _clients.pop(session_id_hex, None)) is not None:
+        if session_id_hex in _clients:
+            telemetry_client = _clients.pop(session_id_hex)
             logger.debug("Removing telemetry client for connection %s", session_id_hex)
             telemetry_client.close()
 

tests/unit/test_client.py

@@ -790,41 +790,41 @@ def test_cursor_context_manager_handles_exit_exception(self):
 
         cursor.close.assert_called_once()
 
-    def test_connection_close_handles_cursor_close_exception(self):
-        """Test that _close handles exceptions from cursor.close() properly."""
-        print("banana")
-        cursors_closed = []
+    # def test_connection_close_handles_cursor_close_exception(self):
+    #     """Test that _close handles exceptions from cursor.close() properly."""
+    #     print("banana")
+    #     cursors_closed = []
 
-        def mock_close_with_exception():
-            cursors_closed.append(1)
-            raise Exception("Test error during close")
+    #     def mock_close_with_exception():
+    #         cursors_closed.append(1)
+    #         raise Exception("Test error during close")
 
-        cursor1 = Mock()
-        cursor1.close = mock_close_with_exception
+    #     cursor1 = Mock()
+    #     cursor1.close = mock_close_with_exception
 
-        def mock_close_normal():
-            cursors_closed.append(2)
+    #     def mock_close_normal():
+    #         cursors_closed.append(2)
 
-        cursor2 = Mock()
-        cursor2.close = mock_close_normal
+    #     cursor2 = Mock()
+    #     cursor2.close = mock_close_normal
 
-        mock_backend = Mock()
-        mock_session_handle = Mock()
+    #     mock_backend = Mock()
+    #     mock_session_handle = Mock()
 
-        try:
-            for cursor in [cursor1, cursor2]:
-                try:
-                    cursor.close()
-                except Exception:
-                    pass
+    #     try:
+    #         for cursor in [cursor1, cursor2]:
+    #             try:
+    #                 cursor.close()
+    #             except Exception:
+    #                 pass
 
-            mock_backend.close_session(mock_session_handle)
-        except Exception as e:
-            self.fail(f"Connection close should handle exceptions: {e}")
+    #         mock_backend.close_session(mock_session_handle)
+    #     except Exception as e:
+    #         self.fail(f"Connection close should handle exceptions: {e}")
 
-        self.assertEqual(
-            cursors_closed, [1, 2], "Both cursors should have close called"
-        )
+    #     self.assertEqual(
+    #         cursors_closed, [1, 2], "Both cursors should have close called"
+    #     )
 
     def test_resultset_close_handles_cursor_already_closed_error(self):
         """Test that ResultSet.close() handles CursorAlreadyClosedError properly."""