Skip to content

Commit 2edff78

Browse files
simple comments on proxy setting
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent de339c0 commit 2edff78

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/databricks/sql/backend/sea/utils/http_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,12 +123,15 @@ def __init__(
123123

124124
# Handle proxy settings
125125
try:
126+
# Try to get system proxy for this scheme (http/https)
126127
proxy = urllib.request.getproxies().get(self.scheme)
127128
except (KeyError, AttributeError):
129+
# No proxy found or getproxies() failed - disable proxy
128130
proxy = None
129131
else:
132+
# Proxy found, but check if this host should bypass proxy
130133
if self.host and urllib.request.proxy_bypass(self.host):
131-
proxy = None
134+
proxy = None # Host bypasses proxy per system rules
132135

133136
if proxy:
134137
parsed_proxy = urllib.parse.urlparse(proxy)

0 commit comments

Comments
 (0)