Skip to content

Commit 3847aca

Browse files
fix warnings
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
1 parent 1dd40a1 commit 3847aca

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

tests/unit/test_telemetry.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,11 @@ def test_connection_failure_sends_correct_telemetry_payload(
349349
"""
350350

351351
error_message = "Could not connect to host"
352-
mock_session.side_effect = Exception(error_message)
352+
# Set up the mock to create a session instance first, then make open() fail
353+
mock_session_instance = MagicMock()
354+
mock_session_instance.is_open = False # Ensure cleanup is safe
355+
mock_session_instance.open.side_effect = Exception(error_message)
356+
mock_session.return_value = mock_session_instance
353357

354358
try:
355359
sql.connect(server_hostname="test-host", http_path="/test-path")
@@ -391,6 +395,7 @@ def test_telemetry_enabled_when_flag_is_true(self, mock_http_request, MockSessio
391395
mock_session_instance = MockSession.return_value
392396
mock_session_instance.guid_hex = "test-session-ff-true"
393397
mock_session_instance.auth_provider = AccessTokenAuthProvider("token")
398+
mock_session_instance.is_open = False # Connection starts closed for test cleanup
394399

395400
# Set up mock HTTP client on the session
396401
mock_http_client = MagicMock()
@@ -418,6 +423,7 @@ def test_telemetry_disabled_when_flag_is_false(
418423
mock_session_instance = MockSession.return_value
419424
mock_session_instance.guid_hex = "test-session-ff-false"
420425
mock_session_instance.auth_provider = AccessTokenAuthProvider("token")
426+
mock_session_instance.is_open = False # Connection starts closed for test cleanup
421427

422428
# Set up mock HTTP client on the session
423429
mock_http_client = MagicMock()
@@ -445,6 +451,7 @@ def test_telemetry_disabled_when_flag_request_fails(
445451
mock_session_instance = MockSession.return_value
446452
mock_session_instance.guid_hex = "test-session-ff-fail"
447453
mock_session_instance.auth_provider = AccessTokenAuthProvider("token")
454+
mock_session_instance.is_open = False # Connection starts closed for test cleanup
448455

449456
# Set up mock HTTP client on the session
450457
mock_http_client = MagicMock()

0 commit comments

Comments
 (0)