Merge branch 'fetch-json-inline' into ext-links-sea

Author: varun-edachali-dbx

src/databricks/sql/backend/sea/backend.py

@@ -407,7 +407,7 @@ def execute_command(
         max_rows: int,
         max_bytes: int,
         lz4_compression: bool,
-        cursor: "Cursor",
+        cursor: Cursor,
         use_cloud_fetch: bool,
         parameters: List[ttypes.TSparkParameter],
         async_op: bool,
@@ -718,7 +718,7 @@ def get_tables(
         session_id: SessionId,
         max_rows: int,
         max_bytes: int,
-        cursor: "Cursor",
+        cursor: Cursor,
         catalog_name: Optional[str] = None,
         schema_name: Optional[str] = None,
         table_name: Optional[str] = None,

src/databricks/sql/backend/sea/utils/filters.py

@@ -112,7 +112,6 @@ def filter_by_column_values(
             result_set,
             lambda row: (
                 len(row) > column_index
-                and isinstance(row[column_index], str)
                 and (
                     row[column_index].upper()
                     if not case_sensitive

tests/unit/test_sea_backend.py

@@ -18,6 +18,7 @@
 from databricks.sql.exc import (
     Error,
     NotSupportedError,
+    ProgrammingError,
     ServerOperationError,
     DatabaseError,
 )
@@ -129,7 +130,7 @@ def test_initialization(self, mock_http_client):
         assert client3.max_download_threads == 5
 
         # Test with invalid HTTP path
-        with pytest.raises(ValueError) as excinfo:
+        with pytest.raises(ProgrammingError) as excinfo:
             SeaDatabricksClient(
                 server_hostname="test-server.databricks.com",
                 port=443,
@@ -195,7 +196,7 @@ def test_session_management(self, sea_client, mock_http_client, thrift_session_i
         )
 
         # Test close_session with invalid ID type
-        with pytest.raises(ValueError) as excinfo:
+        with pytest.raises(ProgrammingError) as excinfo:
             sea_client.close_session(thrift_session_id)
         assert "Not a valid SEA session ID" in str(excinfo.value)
 
@@ -244,7 +245,7 @@ def test_command_execution_sync(
             assert cmd_id_arg.guid == "test-statement-123"
 
         # Test with invalid session ID
-        with pytest.raises(ValueError) as excinfo:
+        with pytest.raises(ProgrammingError) as excinfo:
             mock_thrift_handle = MagicMock()
             mock_thrift_handle.sessionId.guid = b"guid"
             mock_thrift_handle.sessionId.secret = b"secret"
@@ -452,7 +453,7 @@ def test_command_management(
         )
 
         # Test cancel_command with invalid ID
-        with pytest.raises(ValueError) as excinfo:
+        with pytest.raises(ProgrammingError) as excinfo:
             sea_client.cancel_command(thrift_command_id)
         assert "Not a valid SEA command ID" in str(excinfo.value)
 
@@ -466,7 +467,7 @@ def test_command_management(
         )
 
         # Test close_command with invalid ID
-        with pytest.raises(ValueError) as excinfo:
+        with pytest.raises(ProgrammingError) as excinfo:
             sea_client.close_command(thrift_command_id)
         assert "Not a valid SEA command ID" in str(excinfo.value)
 
@@ -525,7 +526,7 @@ def test_command_management(
         assert result.status == CommandState.SUCCEEDED
 
         # Test get_execution_result with invalid ID
-        with pytest.raises(ValueError) as excinfo:
+        with pytest.raises(ProgrammingError) as excinfo:
             sea_client.get_execution_result(thrift_command_id, mock_cursor)
         assert "Not a valid SEA command ID" in str(excinfo.value)
 
@@ -721,7 +722,7 @@ def test_get_schemas(self, sea_client, sea_session_id, mock_cursor):
             )
 
             # Case 3: Without catalog name (should raise ValueError)
-            with pytest.raises(ValueError) as excinfo:
+            with pytest.raises(DatabaseError) as excinfo:
                 sea_client.get_schemas(
                     session_id=sea_session_id,
                     max_rows=100,
@@ -872,7 +873,7 @@ def test_get_columns(self, sea_client, sea_session_id, mock_cursor):
             )
 
             # Case 3: Without catalog name (should raise ValueError)
-            with pytest.raises(ValueError) as excinfo:
+            with pytest.raises(DatabaseError) as excinfo:
                 sea_client.get_columns(
                     session_id=sea_session_id,
                     max_rows=100,