add strong typing for backend parameters arg

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>

Author: varun-edachali-dbx

src/databricks/sql/backend/databricks_client.py

@@ -82,7 +82,7 @@ def execute_command(
         lz4_compression: bool,
         cursor: "Cursor",
         use_cloud_fetch: bool,
-        parameters: List[ttypes.TSparkParameter],
+        parameters: List,
         async_op: bool,
         enforce_embedded_schema_correctness: bool,
     ) -> Union["ResultSet", None]:

src/databricks/sql/backend/sea/backend.py

@@ -85,6 +85,9 @@ class SeaDatabricksClient(DatabricksClient):
     STATEMENT_PATH_WITH_ID = STATEMENT_PATH + "/{}"
     CANCEL_STATEMENT_PATH_WITH_ID = STATEMENT_PATH + "/{}/cancel"
 
+    # SEA constants
+    POLL_INTERVAL_SECONDS = 0.2
+
     def __init__(
         self,
         server_hostname: str,
@@ -383,6 +386,7 @@ def _wait_until_command_done(
         command_id = CommandId.from_sea_statement_id(response.statement_id)
 
         while state in [CommandState.PENDING, CommandState.RUNNING]:
+            time.sleep(self.POLL_INTERVAL_SECONDS)
             state = self.get_query_state(command_id)
 
         self._check_command_not_in_failed_or_closed_state(state, command_id)
@@ -432,9 +436,9 @@ def execute_command(
             for param in parameters:
                 sea_parameters.append(
                     StatementParameter(
-                        name=param.name,
-                        value=param.value,
-                        type=param.type if hasattr(param, "type") else None,
+                        name=param["name"],
+                        value=param["value"],
+                        type=param["type"] if "type" in param else None,
                     )
                 )
 

tests/unit/test_sea_backend.py

@@ -354,10 +354,7 @@ def test_command_execution_advanced(
             "status": {"state": "SUCCEEDED"},
         }
         mock_http_client._make_request.return_value = execute_response
-        param = MagicMock()
-        param.name = "param1"
-        param.value = "value1"
-        param.type = "STRING"
+        param = {"name": "param1", "value": "value1", "type": "STRING"}
 
         with patch.object(sea_client, "get_execution_result"):
             sea_client.execute_command(