Skip to content

Commit 6481851

Browse files
more verbose logging for type conversion fail
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent 29e4846 commit 6481851

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

src/databricks/sql/backend/sea/result_set.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ def _convert_json_types(self, row: List[str]) -> List[Any]:
9292
converted_row = []
9393

9494
for i, value in enumerate(row):
95+
column_name = self.description[i][0]
9596
column_type = self.description[i][1]
9697
precision = self.description[i][4]
9798
scale = self.description[i][5]
@@ -103,7 +104,7 @@ def _convert_json_types(self, row: List[str]) -> List[Any]:
103104
converted_row.append(converted_value)
104105
except Exception as e:
105106
logger.warning(
106-
f"Error converting value '{value}' to {column_type}: {e}"
107+
f"Error converting value '{value}' to {column_type} in column {column_name}: {e}"
107108
)
108109
converted_row.append(value)
109110

src/databricks/sql/backend/sea/utils/conversion.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -155,13 +155,9 @@ def convert_value(
155155
return value
156156

157157
converter_func = SqlTypeConverter.TYPE_MAPPING[sql_type]
158-
try:
159-
if sql_type == SqlType.DECIMAL:
160-
precision = kwargs.get("precision", None)
161-
scale = kwargs.get("scale", None)
162-
return converter_func(value, precision, scale)
163-
else:
164-
return converter_func(value)
165-
except (ValueError, TypeError, decimal.InvalidOperation) as e:
166-
logger.warning(f"Error converting value '{value}' to {sql_type}: {e}")
167-
return value
158+
if sql_type == SqlType.DECIMAL:
159+
precision = kwargs.get("precision", None)
160+
scale = kwargs.get("scale", None)
161+
return converter_func(value, precision, scale)
162+
else:
163+
return converter_func(value)

0 commit comments

Comments
 (0)