Skip to content

Commit 71266b1

Browse files
remove redundant params (byte limit, catalog, schema) in exec command
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent 8da6f5a commit 71266b1

File tree

3 files changed

+6
-19
lines changed

3 files changed

+6
-19
lines changed

examples/experimental/sea_connector_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ def test_sea_result_set_json_array_inline():
105105
)
106106

107107
# Create cursor
108-
cursor = connection.cursor(arraysize=0, buffer_size_bytes=0)
108+
cursor = connection.cursor()
109109

110110
# Execute a query that returns a small result set (will use INLINE disposition)
111111
logger.info("Executing query: SELECT * FROM range(1, 10) AS id")

src/databricks/sql/backend/models/requests.py

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,16 @@ class StatementParameter:
2121
class ExecuteStatementRequest:
2222
"""Request to execute a SQL statement."""
2323

24-
warehouse_id: str
25-
statement: str
2624
session_id: str
25+
statement: str
26+
warehouse_id: str
2727
disposition: str = "EXTERNAL_LINKS"
2828
format: str = "JSON_ARRAY"
29+
result_compression: Optional[str] = None
30+
parameters: Optional[List[StatementParameter]] = None
2931
wait_timeout: str = "10s"
3032
on_wait_timeout: str = "CONTINUE"
3133
row_limit: Optional[int] = None
32-
byte_limit: Optional[int] = None
33-
parameters: Optional[List[StatementParameter]] = None
34-
catalog: Optional[str] = None
35-
schema: Optional[str] = None
36-
result_compression: Optional[str] = None
3734

3835
def to_dict(self) -> Dict[str, Any]:
3936
"""Convert the request to a dictionary for JSON serialization."""
@@ -50,15 +47,6 @@ def to_dict(self) -> Dict[str, Any]:
5047
if self.row_limit is not None and self.row_limit > 0:
5148
result["row_limit"] = self.row_limit
5249

53-
if self.byte_limit is not None and self.byte_limit > 0:
54-
result["byte_limit"] = self.byte_limit
55-
56-
if self.catalog:
57-
result["catalog"] = self.catalog
58-
59-
if self.schema:
60-
result["schema"] = self.schema
61-
6250
if self.result_compression:
6351
result["result_compression"] = self.result_compression
6452

src/databricks/sql/backend/sea_backend.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,8 +353,7 @@ def execute_command(
353353
format=format,
354354
wait_timeout="0s" if async_op else "10s",
355355
on_wait_timeout="CONTINUE",
356-
row_limit=max_rows if max_rows > 0 else None,
357-
byte_limit=max_bytes if max_bytes > 0 else None,
356+
row_limit=max_rows,
358357
parameters=sea_parameters if sea_parameters else None,
359358
result_compression=result_compression,
360359
)

0 commit comments

Comments
 (0)