Commit 75752bf
committed
Implement ResultSet Abstraction (backend interfaces for fetch phase) (#574)
* ensure backend client returns a ResultSet type in backend tests
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* formatting (black)
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* newline for cleanliness
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* fix circular import
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* formatting (black)
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* to_hex_id -> get_hex_id
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* better comment on protocol version getter
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* formatting (black)
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* stricter typing for cursor
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* correct typing
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* correct tests and merge artifacts
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* remove accidentally modified workflow files
remnants of old merge
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* chore: remove accidentally modified workflow files
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* add back accidentally removed docstrings
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* clean up docstrings
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* log hex
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* remove unnecessary _replace call
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* add __str__ for CommandId
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* take TOpenSessionResp in get_protocol_version to maintain existing interface
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* active_op_handle -> active_mmand_id
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* ensure None returned for close_command
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* account for ResultSet return in new pydocs
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* pydoc for types
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* move common state to ResultSet aprent
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* stronger typing in resultSet behaviour
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* remove redundant patch in test
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* add has_been_closed_server_side assertion
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* remove redundancies in tests
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* more robust close check
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* use normalised state in e2e test
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* simplify corrected test
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* add line gaps after multi-line pydocs for consistency
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
* use normalised CommandState type in ExecuteResponse
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
---------
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>1 parent 57370b3 commit 75752bf
File tree
14 files changed
+775
-510
lines changed- src/databricks/sql
- backend
- utils
- tests
- e2e
- unit
14 files changed
+775
-510
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
22 | 28 | | |
23 | 29 | | |
24 | 30 | | |
| |||
81 | 87 | | |
82 | 88 | | |
83 | 89 | | |
84 | | - | |
| 90 | + | |
85 | 91 | | |
86 | 92 | | |
87 | 93 | | |
| |||
101 | 107 | | |
102 | 108 | | |
103 | 109 | | |
104 | | - | |
| 110 | + | |
105 | 111 | | |
106 | 112 | | |
107 | 113 | | |
| |||
130 | 136 | | |
131 | 137 | | |
132 | 138 | | |
133 | | - | |
| 139 | + | |
134 | 140 | | |
135 | 141 | | |
136 | 142 | | |
| |||
140 | 146 | | |
141 | 147 | | |
142 | 148 | | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | 149 | | |
147 | 150 | | |
148 | 151 | | |
149 | 152 | | |
150 | 153 | | |
151 | 154 | | |
152 | 155 | | |
153 | | - | |
| 156 | + | |
154 | 157 | | |
155 | 158 | | |
156 | 159 | | |
| |||
160 | 163 | | |
161 | 164 | | |
162 | 165 | | |
163 | | - | |
| 166 | + | |
164 | 167 | | |
165 | 168 | | |
166 | 169 | | |
| |||
175 | 178 | | |
176 | 179 | | |
177 | 180 | | |
178 | | - | |
| 181 | + | |
179 | 182 | | |
180 | 183 | | |
181 | 184 | | |
| |||
187 | 190 | | |
188 | 191 | | |
189 | 192 | | |
190 | | - | |
| 193 | + | |
191 | 194 | | |
192 | 195 | | |
193 | 196 | | |
| |||
203 | 206 | | |
204 | 207 | | |
205 | 208 | | |
206 | | - | |
| 209 | + | |
207 | 210 | | |
208 | 211 | | |
209 | 212 | | |
| |||
217 | 220 | | |
218 | 221 | | |
219 | 222 | | |
220 | | - | |
| 223 | + | |
221 | 224 | | |
222 | 225 | | |
223 | 226 | | |
| |||
234 | 237 | | |
235 | 238 | | |
236 | 239 | | |
237 | | - | |
| 240 | + | |
238 | 241 | | |
239 | 242 | | |
240 | 243 | | |
| |||
250 | 253 | | |
251 | 254 | | |
252 | 255 | | |
253 | | - | |
| 256 | + | |
254 | 257 | | |
255 | 258 | | |
256 | 259 | | |
| |||
269 | 272 | | |
270 | 273 | | |
271 | 274 | | |
272 | | - | |
| 275 | + | |
273 | 276 | | |
274 | 277 | | |
275 | 278 | | |
| |||
287 | 290 | | |
288 | 291 | | |
289 | 292 | | |
290 | | - | |
| 293 | + | |
291 | 294 | | |
292 | 295 | | |
293 | 296 | | |
| |||
306 | 309 | | |
307 | 310 | | |
308 | 311 | | |
309 | | - | |
| 312 | + | |
310 | 313 | | |
311 | 314 | | |
312 | 315 | | |
| |||
324 | 327 | | |
325 | 328 | | |
326 | 329 | | |
327 | | - | |
| 330 | + | |
328 | 331 | | |
329 | 332 | | |
330 | 333 | | |
| |||
0 commit comments