logging, test fixture

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

Author: saishreeeee

src/databricks/sql/telemetry/latency_logger.py

@@ -22,24 +22,9 @@ class TelemetryExtractor:
     """
 
     def __init__(self, obj):
-        """
-        Initialize the extractor with an object to wrap.
-
-        Args:
-            obj: The object to extract telemetry information from.
-        """
         self._obj = obj
 
     def __getattr__(self, name):
-        """
-        Delegate attribute access to the wrapped object.
-
-        Args:
-            name (str): The name of the attribute to access.
-
-        Returns:
-            The attribute value from the wrapped object.
-        """
         return getattr(self._obj, name)
 
     def get_session_id_hex(self):
@@ -155,7 +140,7 @@ def get_extractor(obj):
     elif obj.__class__.__name__ == "ResultSet":
         return ResultSetExtractor(obj)
     else:
-        logger.error(f"No extractor found for {obj.__class__.__name__}")
+        logger.debug("No extractor found for %s", obj.__class__.__name__)
         return None
 
 

src/databricks/sql/telemetry/telemetry_client.py

@@ -239,8 +239,9 @@ def _telemetry_request_callback(self, future):
                 logger.debug("Telemetry request completed successfully")
             else:
                 logger.debug(
-                    "Telemetry request failed with status code: %s",
+                    "Telemetry request failed with status code: %s, response: %s",
                     response.status_code,
+                    response.text,
                 )
 
         except Exception as e:

tests/unit/test_telemetry.py

@@ -18,22 +18,6 @@
 )
 
 
-@pytest.fixture
-def telemetry_system_reset():
-    """Reset telemetry system state before each test."""
-    TelemetryClientFactory._clients.clear()
-    if TelemetryClientFactory._executor:
-        TelemetryClientFactory._executor.shutdown(wait=True)
-    TelemetryClientFactory._executor = None
-    TelemetryClientFactory._initialized = False
-    yield
-    TelemetryClientFactory._clients.clear()
-    if TelemetryClientFactory._executor:
-        TelemetryClientFactory._executor.shutdown(wait=True)
-    TelemetryClientFactory._executor = None
-    TelemetryClientFactory._initialized = False
-
-
 @pytest.fixture
 def mock_telemetry_client():
     """Create a mock telemetry client for testing."""
@@ -200,7 +184,22 @@ def test_auth_flow_detection(self):
 class TestTelemetryFactory:
     """Tests for TelemetryClientFactory lifecycle and management."""
 
-    def test_client_lifecycle_flow(self, telemetry_system_reset):
+    @pytest.fixture(autouse=True)
+    def telemetry_system_reset(self):
+        """Reset telemetry system state before each test."""
+        TelemetryClientFactory._clients.clear()
+        if TelemetryClientFactory._executor:
+            TelemetryClientFactory._executor.shutdown(wait=True)
+        TelemetryClientFactory._executor = None
+        TelemetryClientFactory._initialized = False
+        yield
+        TelemetryClientFactory._clients.clear()
+        if TelemetryClientFactory._executor:
+            TelemetryClientFactory._executor.shutdown(wait=True)
+        TelemetryClientFactory._executor = None
+        TelemetryClientFactory._initialized = False
+
+    def test_client_lifecycle_flow(self):
         """Test complete client lifecycle: initialize -> use -> close."""
         session_id_hex = "test-session"
         auth_provider = AccessTokenAuthProvider("token")
@@ -226,7 +225,7 @@ def test_client_lifecycle_flow(self, telemetry_system_reset):
         client = TelemetryClientFactory.get_telemetry_client(session_id_hex)
         assert isinstance(client, NoopTelemetryClient)
 
-    def test_disabled_telemetry_flow(self, telemetry_system_reset):
+    def test_disabled_telemetry_flow(self):
         """Test that disabled telemetry uses NoopTelemetryClient."""
         session_id_hex = "test-session"
 
@@ -240,7 +239,7 @@ def test_disabled_telemetry_flow(self, telemetry_system_reset):
         client = TelemetryClientFactory.get_telemetry_client(session_id_hex)
         assert isinstance(client, NoopTelemetryClient)
 
-    def test_factory_error_handling(self, telemetry_system_reset):
+    def test_factory_error_handling(self):
         """Test that factory errors fall back to NoopTelemetryClient."""
         session_id = "test-session"
 
@@ -258,7 +257,7 @@ def test_factory_error_handling(self, telemetry_system_reset):
         client = TelemetryClientFactory.get_telemetry_client(session_id)
         assert isinstance(client, NoopTelemetryClient)
 
-    def test_factory_shutdown_flow(self, telemetry_system_reset):
+    def test_factory_shutdown_flow(self):
         """Test factory shutdown when last client is removed."""
         session1 = "session-1"
         session2 = "session-2"