Skip to content

Commit 9f19c88

Browse files
committed
perf: Skip feature flag fetch when telemetry is force enabled
When force_enable_telemetry=True, skip the feature flag network call entirely since we already know telemetry should be enabled. This optimization: - Eliminates unnecessary network call during connection init - Faster connection setup when telemetry is forced on - Clearer control flow with early returns
1 parent 695ea7f commit 9f19c88

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/databricks/sql/telemetry/telemetry_client.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -110,18 +110,21 @@ def get_auth_flow(auth_provider):
110110

111111
@staticmethod
112112
def is_telemetry_enabled(connection: "Connection") -> bool:
113+
# Fast path: force enabled - skip feature flag fetch entirely
113114
if connection.force_enable_telemetry:
114115
return True
115116

116-
if connection.enable_telemetry:
117-
context = FeatureFlagsContextFactory.get_instance(connection)
118-
flag_value = context.get_flag_value(
119-
TelemetryHelper.TELEMETRY_FEATURE_FLAG_NAME, default_value=False
120-
)
121-
return str(flag_value).lower() == "true"
122-
else:
117+
# Fast path: disabled - no need to check feature flag
118+
if not connection.enable_telemetry:
123119
return False
124120

121+
# Only fetch feature flags when enable_telemetry=True and not forced
122+
context = FeatureFlagsContextFactory.get_instance(connection)
123+
flag_value = context.get_flag_value(
124+
TelemetryHelper.TELEMETRY_FEATURE_FLAG_NAME, default_value=False
125+
)
126+
return str(flag_value).lower() == "true"
127+
125128

126129
class NoopTelemetryClient(BaseTelemetryClient):
127130
"""

0 commit comments

Comments
 (0)