Skip to content

Commit ad45046

Browse files
redundancies + op_handle -> command_id
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent 1aec8b9 commit ad45046

File tree

3 files changed

+4
-19
lines changed

3 files changed

+4
-19
lines changed

src/databricks/sql/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -876,7 +876,7 @@ def get_async_execution_result(self):
876876
operation_state = self.get_query_state()
877877
if operation_state == CommandState.SUCCEEDED:
878878
self.active_result_set = self.backend.get_execution_result(
879-
self.active_op_handle, self
879+
self.active_command_id, self
880880
)
881881

882882
if self.active_result_set and self.active_result_set.is_staging_operation:

src/databricks/sql/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ def build_queue(
7474
Returns:
7575
ResultSetQueue
7676
"""
77-
# Handle Thrift result data
77+
7878
if (
7979
row_set_type == TSparkRowSetType.ARROW_BASED_SET
8080
and t_row_set is not None

tests/unit/test_result_set_queue_factories.py

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,32 +3,17 @@
33
"""
44

55
import unittest
6-
from unittest.mock import MagicMock, patch
7-
import sys
8-
from typing import Dict, List, Any, Optional
9-
10-
# Add the necessary path to import the modules
11-
sys.path.append("/home/varun.edachali/conn/databricks-sql-python/src")
12-
13-
try:
14-
import pyarrow
15-
except ImportError:
16-
pyarrow = None
6+
from unittest.mock import MagicMock
177

188
from databricks.sql.utils import (
19-
ThriftResultSetQueueFactory,
209
SeaResultSetQueueFactory,
2110
JsonQueue,
22-
ArrowQueue,
23-
ColumnQueue,
24-
CloudFetchQueue,
2511
)
26-
from databricks.sql.thrift_api.TCLIService.ttypes import TSparkRowSetType, TRowSet
2712
from databricks.sql.backend.models import ResultData
2813

2914

3015
class TestResultSetQueueFactories(unittest.TestCase):
31-
"""Tests for the ThriftResultSetQueueFactory and SeaResultSetQueueFactory classes."""
16+
"""Tests for the SeaResultSetQueueFactory classes."""
3217

3318
def test_sea_result_set_queue_factory_with_data(self):
3419
"""Test SeaResultSetQueueFactory with data."""

0 commit comments

Comments
 (0)