reduce diff

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>

Author: varun-edachali-dbx

src/databricks/sql/session.py

@@ -126,9 +126,10 @@ def open(self):
             catalog=self.catalog,
             schema=self.schema,
         )
+
         self.protocol_version = self.get_protocol_version(self._session_id)
         self.is_open = True
-        logger.info("Successfully opened session " + str(self.guid_hex))
+        logger.info("Successfully opened session %s", str(self.guid_hex))
 
     @staticmethod
     def get_protocol_version(session_id: SessionId):

src/databricks/sql/types.py

@@ -187,7 +187,6 @@ def __contains__(self, item: Any) -> bool:
     # let object acts like class
     def __call__(self, *args: Any) -> "Row":
         """create new Row object"""
-
         if len(args) > len(self):
             raise ValueError(
                 "Can not create Row with fields %s, expected %d values "
@@ -230,15 +229,13 @@ def __reduce__(
         self,
     ) -> Union[str, Tuple[Any, ...]]:
         """Returns a tuple so Python knows how to pickle Row."""
-
         if hasattr(self, "__fields__"):
             return (_create_row, (self.__fields__, tuple(self)))
         else:
             return tuple.__reduce__(self)
 
     def __repr__(self) -> str:
         """Printable representation of Row used in Python REPL."""
-
         if hasattr(self, "__fields__"):
             return "Row(%s)" % ", ".join(
                 "%s=%r" % (k, v) for k, v in zip(self.__fields__, tuple(self))

tests/unit/test_client.py

@@ -105,17 +105,13 @@ def test_closing_connection_closes_commands(self, mock_thrift_client_class):
 
                 # Mock the execute response with controlled state
                 mock_execute_response = Mock(spec=ExecuteResponse)
-
-                mock_execute_response.command_id = Mock(spec=CommandId)
-                mock_execute_response.status = (
-                    CommandState.SUCCEEDED if not closed else CommandState.CLOSED
-                )
+                mock_execute_response.status = initial_state
                 mock_execute_response.has_been_closed_server_side = closed
                 mock_execute_response.is_staging_operation = False
                 mock_execute_response.command_id = Mock(spec=CommandId)
                 mock_execute_response.description = []
 
-                # Mock the backend that will be used by the real ThriftResultSet
+                # Mock the backend that will be used
                 mock_backend = Mock(spec=ThriftDatabricksClient)
                 mock_backend.staging_allowed_local_path = None
                 mock_backend.fetch_results.return_value = (Mock(), False, 0)
@@ -137,15 +133,13 @@ def test_closing_connection_closes_commands(self, mock_thrift_client_class):
                 # Mock execute_command to return our real result set
                 cursor.backend.execute_command = Mock(return_value=real_result_set)
 
-                # Execute a command - this should set cursor.active_result_set to our real result set
+                # Execute a command
                 cursor.execute("SELECT 1")
 
-                # Close the connection - this should trigger the real close chain:
-                # connection.close() -> cursor.close() -> result_set.close()
+                # Close the connection
                 connection.close()
 
-                # Verify the REAL close logic worked through the chain:
-                # 1. has_been_closed_server_side should always be True after close()
+                # Verify the close logic worked:
                 assert real_result_set.has_been_closed_server_side is True
 
                 # 2. op_state should always be CLOSED after close()

tests/unit/test_cloud_fetch_queue.py

@@ -162,8 +162,6 @@ def test_next_n_rows_0_rows(self, mock_create_next_table):
         result = queue.next_n_rows(0)
         assert result.num_rows == 0
         assert queue.table_row_index == 0
-        # Instead of comparing tables directly, just check the row count
-        # This avoids issues with empty table schema differences
 
     @patch("databricks.sql.utils.ThriftCloudFetchQueue._create_next_table")
     def test_next_n_rows_partial_table(self, mock_create_next_table):