Skip to content

Commit c038f22

Browse files
fix: convert sea statement id to CommandId type
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent 91d28b2 commit c038f22

File tree

2 files changed

+13
-16
lines changed

2 files changed

+13
-16
lines changed

src/databricks/sql/backend/sea/backend.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,6 @@
4040
GetStatementResponse,
4141
CreateSessionResponse,
4242
)
43-
from databricks.sql.backend.sea.models.responses import (
44-
parse_status,
45-
parse_manifest,
46-
parse_result,
47-
)
4843

4944
logger = logging.getLogger(__name__)
5045

@@ -341,10 +336,12 @@ def _results_message_to_execute_response(
341336
description = self._extract_description_from_manifest(response.manifest)
342337

343338
# Check for compression
344-
lz4_compressed = response.manifest.result_compression == "LZ4_FRAME"
339+
lz4_compressed = (
340+
response.manifest.result_compression == ResultCompression.LZ4_FRAME
341+
)
345342

346343
execute_response = ExecuteResponse(
347-
command_id=response.statement_id,
344+
command_id=CommandId.from_sea_statement_id(response.statement_id),
348345
status=response.status.state,
349346
description=description,
350347
has_been_closed_server_side=False,

src/databricks/sql/backend/sea/models/responses.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
)
1919

2020

21-
def parse_status(data: Dict[str, Any]) -> StatementStatus:
21+
def _parse_status(data: Dict[str, Any]) -> StatementStatus:
2222
"""Parse status from response data."""
2323
status_data = data.get("status", {})
2424
error = None
@@ -40,7 +40,7 @@ def parse_status(data: Dict[str, Any]) -> StatementStatus:
4040
)
4141

4242

43-
def parse_manifest(data: Dict[str, Any]) -> ResultManifest:
43+
def _parse_manifest(data: Dict[str, Any]) -> ResultManifest:
4444
"""Parse manifest from response data."""
4545

4646
manifest_data = data.get("manifest", {})
@@ -69,7 +69,7 @@ def parse_manifest(data: Dict[str, Any]) -> ResultManifest:
6969
)
7070

7171

72-
def parse_result(data: Dict[str, Any]) -> ResultData:
72+
def _parse_result(data: Dict[str, Any]) -> ResultData:
7373
"""Parse result data from response data."""
7474
result_data = data.get("result", {})
7575
external_links = None
@@ -118,9 +118,9 @@ def from_dict(cls, data: Dict[str, Any]) -> "ExecuteStatementResponse":
118118
"""Create an ExecuteStatementResponse from a dictionary."""
119119
return cls(
120120
statement_id=data.get("statement_id", ""),
121-
status=parse_status(data),
122-
manifest=parse_manifest(data),
123-
result=parse_result(data),
121+
status=_parse_status(data),
122+
manifest=_parse_manifest(data),
123+
result=_parse_result(data),
124124
)
125125

126126

@@ -138,9 +138,9 @@ def from_dict(cls, data: Dict[str, Any]) -> "GetStatementResponse":
138138
"""Create a GetStatementResponse from a dictionary."""
139139
return cls(
140140
statement_id=data.get("statement_id", ""),
141-
status=parse_status(data),
142-
manifest=parse_manifest(data),
143-
result=parse_result(data),
141+
status=_parse_status(data),
142+
manifest=_parse_manifest(data),
143+
result=_parse_result(data),
144144
)
145145

146146

0 commit comments

Comments
 (0)