Skip to content

Commit c106b95

Browse files
committed
actual send telemetry
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
1 parent 1355283 commit c106b95

File tree

1 file changed

+3
-18
lines changed

1 file changed

+3
-18
lines changed

tests/e2e/test_concurrent_telemetry.py

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,7 @@ def send_telemetry_wrapper(self_client, events):
6060
captured_telemetry.extend(events)
6161
original_send_telemetry(self_client, events)
6262

63-
def callback_wrapper(self_client, response):
64-
with captured_responses_lock:
65-
captured_responses.append(response)
66-
original_callback(self_client, response)
67-
68-
with patch.object(TelemetryClient, "_send_telemetry", send_telemetry_wrapper), patch.object(TelemetryClient, "_telemetry_request_callback", callback_wrapper):
63+
with patch.object(TelemetryClient, "_send_telemetry", send_telemetry_wrapper):
6964

7065
def execute_query_worker(thread_id):
7166
"""Each thread creates a connection and executes a query."""
@@ -81,20 +76,10 @@ def execute_query_worker(thread_id):
8176
TelemetryClientFactory._executor.shutdown(wait=True)
8277

8378
# --- VERIFICATION ---
84-
# print event by event in a readable format
85-
for event in captured_telemetry:
86-
print(event)
87-
print("-"*100)
88-
89-
# print response by response in a readable format
90-
for response in captured_responses:
91-
print(response)
92-
print("-"*100)
93-
94-
assert len(captured_telemetry) == num_threads * 4 # 4 events per thread (initial_telemetry_log, 3 latency_logs (execute_command, fetchall_arrow, _convert_arrow_table))
79+
assert len(captured_telemetry) == num_threads * 3 # 4 events per thread (initial_telemetry_log, 2 latency_logs (execute, fetchall))
9580

9681
events_with_latency = [
9782
e for e in captured_telemetry
9883
if e.entry.sql_driver_log.operation_latency_ms is not None and e.entry.sql_driver_log.sql_statement_id is not None
9984
]
100-
assert len(events_with_latency) == num_threads * 3 # 3 events per thread (execute_command, fetchall_arrow, _convert_arrow_table)
85+
assert len(events_with_latency) == num_threads * 2 # 2 events per thread (execute, fetchall)

0 commit comments

Comments
 (0)