Skip to content

Commit dfc32b4

Browse files
Merge branch 'sea-migration' into ext-links-sea
2 parents 7985639 + dc1cb6d commit dfc32b4

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/databricks/sql/backend/databricks_client.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ def execute_command(
110110
parameters: List of parameters to bind to the query
111111
async_op: Whether to execute the command asynchronously
112112
enforce_embedded_schema_correctness: Whether to enforce schema correctness
113+
row_limit: Maximum number of rows in the response.
113114
114115
Returns:
115116
If async_op is False, returns a ResultSet object containing the

tests/unit/test_sea_backend.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
_filter_session_configuration,
1414
)
1515
from databricks.sql.backend.types import SessionId, CommandId, CommandState, BackendType
16+
from databricks.sql.parameters.native import IntegerParameter, TDbsqlParameter
1617
from databricks.sql.thrift_api.TCLIService import ttypes
1718
from databricks.sql.types import SSLOptions
1819
from databricks.sql.auth.authenticators import AuthProvider
@@ -356,7 +357,8 @@ def test_command_execution_advanced(
356357
"status": {"state": "SUCCEEDED"},
357358
}
358359
mock_http_client._make_request.return_value = execute_response
359-
param = ttypes.TSparkParameter(name="param1", value="value1", type="STRING")
360+
dbsql_param = IntegerParameter(name="param1", value=1)
361+
param = dbsql_param.as_tspark_param(named=True)
360362

361363
with patch.object(sea_client, "get_execution_result"):
362364
sea_client.execute_command(
@@ -375,8 +377,8 @@ def test_command_execution_advanced(
375377
assert "parameters" in kwargs["data"]
376378
assert len(kwargs["data"]["parameters"]) == 1
377379
assert kwargs["data"]["parameters"][0]["name"] == "param1"
378-
assert kwargs["data"]["parameters"][0]["value"] == "value1"
379-
assert kwargs["data"]["parameters"][0]["type"] == "STRING"
380+
assert kwargs["data"]["parameters"][0]["value"] == "1"
381+
assert kwargs["data"]["parameters"][0]["type"] == "INT"
380382

381383
# Test execution failure
382384
mock_http_client.reset_mock()

0 commit comments

Comments
 (0)