Skip to content

Commit e3fe299

Browse files
remove excess fetch_results mocks
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
1 parent 45a32be commit e3fe299

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

tests/unit/test_client.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,6 @@ def test_closing_result_set_hard_closes_commands(self):
213213
type(mock_connection).session = PropertyMock(return_value=mock_session)
214214

215215
mock_thrift_backend.fetch_results.return_value = (Mock(), False)
216-
217216
result_set = ThriftResultSet(
218217
mock_connection, mock_results_response, mock_thrift_backend
219218
)
@@ -479,7 +478,6 @@ def make_fake_row_slice(n_rows):
479478
mock_aq = Mock()
480479
mock_aq.next_n_rows.side_effect = make_fake_row_slice
481480
mock_thrift_backend.execute_command.return_value.arrow_queue = mock_aq
482-
mock_thrift_backend.fetch_results.return_value = (mock_aq, True)
483481

484482
cursor = client.Cursor(Mock(), mock_thrift_backend)
485483
cursor.execute("foo")

tests/unit/test_thrift_backend.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1177,8 +1177,6 @@ def test_execute_statement_calls_client_and_handle_execute_response(
11771177
)
11781178
cursor_mock = Mock()
11791179

1180-
thrift_backend.fetch_results = Mock(return_value=(Mock(), False))
1181-
11821180
result = thrift_backend.execute_command(
11831181
"foo", Mock(), 100, 200, Mock(), cursor_mock
11841182
)
@@ -1214,8 +1212,6 @@ def test_get_catalogs_calls_client_and_handle_execute_response(
12141212
)
12151213
cursor_mock = Mock()
12161214

1217-
thrift_backend.fetch_results = Mock(return_value=(Mock(), False))
1218-
12191215
result = thrift_backend.get_catalogs(Mock(), 100, 200, cursor_mock)
12201216
# Verify the result is a ResultSet
12211217
self.assertIsInstance(result, ResultSet)
@@ -1247,8 +1243,6 @@ def test_get_schemas_calls_client_and_handle_execute_response(
12471243
)
12481244
cursor_mock = Mock()
12491245

1250-
thrift_backend.fetch_results = Mock(return_value=(Mock(), False))
1251-
12521246
result = thrift_backend.get_schemas(
12531247
Mock(),
12541248
100,
@@ -1289,8 +1283,6 @@ def test_get_tables_calls_client_and_handle_execute_response(
12891283
)
12901284
cursor_mock = Mock()
12911285

1292-
thrift_backend.fetch_results = Mock(return_value=(Mock(), False))
1293-
12941286
result = thrift_backend.get_tables(
12951287
Mock(),
12961288
100,
@@ -1335,8 +1327,6 @@ def test_get_columns_calls_client_and_handle_execute_response(
13351327
)
13361328
cursor_mock = Mock()
13371329

1338-
thrift_backend.fetch_results = Mock(return_value=(Mock(), False))
1339-
13401330
result = thrift_backend.get_columns(
13411331
Mock(),
13421332
100,
@@ -2261,8 +2251,6 @@ def test_execute_command_sets_complex_type_fields_correctly(
22612251
**complex_arg_types,
22622252
)
22632253

2264-
thrift_backend.fetch_results = Mock(return_value=(Mock(), False))
2265-
22662254
thrift_backend.execute_command(Mock(), Mock(), 100, 100, Mock(), Mock())
22672255
t_execute_statement_req = tcli_service_instance.ExecuteStatement.call_args[
22682256
0

0 commit comments

Comments
 (0)