Skip to content

fix(theme): Properly set logo url on ErrorSection.tsx #15295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

fix(theme): Properly set logo url on ErrorSection.tsx #15295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions datahub-web-react/src/app/shared/error/ErrorSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import React from 'react';
import styled, { useTheme } from 'styled-components';

import { ANTD_GRAY } from '@app/entity/shared/constants';
import { resolveRuntimePath } from '@utils/runtimeBasePath';

import dataHubLogo from '@images/datahublogo.png';

const Section = styled.div`
width: auto;
Expand Down Expand Up @@ -60,7 +61,7 @@ const resources = [

export const ErrorSection = (): JSX.Element => {
const themeConfig = useTheme();
const themeLogo = resolveRuntimePath(themeConfig.assets.logoUrl || '@images/datahublogo.png');
const themeLogo = themeConfig.assets.logoUrl || dataHubLogo;

return (
<Section>
Expand Down
Loading