Commit ace502a
authored
Deprecate split view modifiers (#29)
After some experimentation I came to the conclusion that split view
"transitions" are not meant to be modified directly. They're not even a
thing in itself, really.
Instead, it should be the stack navigation view *within* the split view
that can and should have their transition modified directly.
So I deprecated all the split view modifiers and flattened the 2 stack
modifiers into one: `.navigationTransition`. In addition to this, a
useful runtime warning will let you know when you're holding it wrong.
This drastically simplifies the API surface to a single entry point and
is, I believe, a step in the right direction to easing the entry barrier
for this library.1 parent 0ac3c1a commit ace502a
4 files changed
+81
-252
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
15 | | - | |
16 | | - | |
| 14 | + | |
| 15 | + | |
17 | 16 | | |
18 | 17 | | |
19 | 18 | | |
20 | | - | |
| 19 | + | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
28 | 27 | | |
29 | 28 | | |
30 | 29 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
| 30 | + | |
40 | 31 | | |
41 | 32 | | |
42 | 33 | | |
| |||
45 | 36 | | |
46 | 37 | | |
47 | 38 | | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
| 39 | + | |
56 | 40 | | |
57 | 41 | | |
58 | 42 | | |
| |||
62 | 46 | | |
63 | 47 | | |
64 | 48 | | |
65 | | - | |
| 49 | + | |
66 | 50 | | |
67 | 51 | | |
68 | 52 | | |
69 | 53 | | |
70 | 54 | | |
71 | 55 | | |
72 | 56 | | |
73 | | - | |
| 57 | + | |
74 | 58 | | |
75 | 59 | | |
76 | 60 | | |
77 | 61 | | |
78 | 62 | | |
79 | 63 | | |
80 | 64 | | |
81 | | - | |
| 65 | + | |
82 | 66 | | |
83 | 67 | | |
84 | 68 | | |
| |||
129 | 113 | | |
130 | 114 | | |
131 | 115 | | |
132 | | - | |
| 116 | + | |
133 | 117 | | |
134 | 118 | | |
135 | 119 | | |
136 | 120 | | |
137 | 121 | | |
138 | | - | |
| 122 | + | |
139 | 123 | | |
140 | 124 | | |
141 | 125 | | |
| |||
0 commit comments