Skip to content

per-file version assignment check too naive.  #6

@kentfredric

Description

@kentfredric

As per cpants/www-cpants#10

I initially thought this was due to using

package Foo { }

Notation, but its worse than that,

Simply using

package Bar;
{
   $Bar::VERSION = 
}

instead of

package Bar;
{ 
   $VERSION =
}

Will cause it to fail this test.

And this covers everything created by Dist::Zilla::Plugin::PkgVersion

You may want to use Module::Metadata to support this feature, as this already parses $Foo::VERSION formating, both with and without pkg NAME BLOCK notation.

I'm not sure about pkg NAME VERSION BLOCK notation though.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions