Suggestions from #2
Description
Comment from GRIMBERT.Oliver on the 4D Forum
As per: https://discuss.4d.com/t/codeanalysis-component-now-open-source/26221/7?u=beaubien.dani
A little feedback on snippet…
The idea is just superbe ! 👏 👏 👏
Some points to review:
- the UI can be improved :slight_smile:
- this works only for EN machine. ie I had nothing on palette, till I understood: Process number(“Design process”) → in french Process number(“Process développement”), and so one for other languages
- It could be good to have a macro to add a selection directly to a new window
- add drag and drop text from a method selection to the palette => proposes directly a new snippet with the selection in it and the window type selected.
- and when you add a new snippet, no need for “default snippet”, as if we drag&drop from method
- , we then have to remove this text. Empty is better !
This is my 2 cents contribution…
And I discovered in Class WindowTypeFinder, you manage EN and FR.
So just a little miss in FM SlippetSelector_d:
Form.designProcessId:=Process number("Design process")+Process number("Process développement")
Or to use a xliff file for that , and all other definitions in the class, they will be unique!