Skip to content
This repository was archived by the owner on Apr 9, 2025. It is now read-only.

Commit 6f05898

Browse files
authored
Merge pull request #48 from dbssman/bugfix/47-native-handler-overwrites-value-of-custom-components
🔨 Fix custom element detection
2 parents 7369507 + 138efe8 commit 6f05898

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "vue-form-handler",
3-
"version": "0.2.4",
3+
"version": "0.2.5",
44
"type": "module",
55
"license": "MIT",
66
"author": "Dennis R. Bosmans",

src/logic/refFn.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export default (name: string, _refs: Refs, values: any) => (fieldRef: any) => {
66
delete _refs[name]
77
return
88
}
9-
if (!fieldRef.nodeName || !isNativeControl(fieldRef)) {
9+
if (fieldRef.$el || !fieldRef.nodeName || !isNativeControl(fieldRef)) {
1010
//TODO: Correctly type this in order to expect a fixed data structure
1111
_refs[name].ref = {
1212
type: 'custom'

src/useFormHandler.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ import {
2121
IsValidForm,
2222
Refs,
2323
ValidationsConfiguration,
24-
Unregister
24+
Unregister,
25+
FieldReference
2526
} from './types';
2627
import { reactive, readonly, unref, watch } from '@vue/runtime-core'
2728
import { isEqual } from 'lodash-es'
@@ -236,7 +237,12 @@ export const useFormHandler: UseFormHandler = ({
236237
isTouched: !!formState.touched[name],
237238
}),
238239
...(native !== false && {
239-
onChange: async () => await handleChange(name, getNativeFieldValue(_refs[name].ref)),
240+
onChange: async () => {
241+
if (!_refs[name].ref || (_refs[name].ref as FieldReference).type === 'custom') {
242+
return
243+
}
244+
await handleChange(name, getNativeFieldValue(_refs[name].ref))
245+
},
240246
}),
241247
...(useNativeValidation && {
242248
...({

0 commit comments

Comments
 (0)