From ac4fc89939fb6622ff9f7dd43cd3db800b57f3c4 Mon Sep 17 00:00:00 2001 From: Brian White <44818189+brianrudolf@users.noreply.github.com> Date: Mon, 15 Sep 2025 13:27:02 -0400 Subject: [PATCH 1/4] Allow removing engine resource limits --- .../templates/engine/engine.deployment.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/charts/deepgram-self-hosted/templates/engine/engine.deployment.yaml b/charts/deepgram-self-hosted/templates/engine/engine.deployment.yaml index df91dd9..2a306d1 100644 --- a/charts/deepgram-self-hosted/templates/engine/engine.deployment.yaml +++ b/charts/deepgram-self-hosted/templates/engine/engine.deployment.yaml @@ -108,13 +108,17 @@ spec: resources: requests: memory: "{{ $.Values.engine.resources.requests.memory }}" - cpu: "{{ $.Values.engine.resources.requests.cpu }}" + cpu: "{{ .Values.engine.resources.requests.cpu }}" {{- if gt (int $.Values.engine.resources.requests.gpu) 0 }} nvidia.com/gpu: {{ $.Values.engine.resources.requests.gpu }} {{- end }} limits: + {{- if .Values.engine.resources.limits.memory }} memory: "{{ $.Values.engine.resources.limits.memory }}" + {{- end }} + {{- if .Values.engine.resources.limits.cpu }} cpu: "{{ $.Values.engine.resources.limits.cpu }}" + {{- end }} {{- if gt (int $.Values.engine.resources.limits.gpu) 0 }} nvidia.com/gpu: {{ $.Values.engine.resources.limits.gpu }} {{- end }} From c140eace76463136dd764355b817f3c4d8ab46fb Mon Sep 17 00:00:00 2001 From: Brian White <44818189+brianrudolf@users.noreply.github.com> Date: Mon, 15 Sep 2025 13:28:55 -0400 Subject: [PATCH 2/4] Update engine.deployment.yaml --- .../templates/engine/engine.deployment.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/deepgram-self-hosted/templates/engine/engine.deployment.yaml b/charts/deepgram-self-hosted/templates/engine/engine.deployment.yaml index 2a306d1..ed1c8f3 100644 --- a/charts/deepgram-self-hosted/templates/engine/engine.deployment.yaml +++ b/charts/deepgram-self-hosted/templates/engine/engine.deployment.yaml @@ -108,7 +108,7 @@ spec: resources: requests: memory: "{{ $.Values.engine.resources.requests.memory }}" - cpu: "{{ .Values.engine.resources.requests.cpu }}" + cpu: "{{ $.Values.engine.resources.requests.cpu }}" {{- if gt (int $.Values.engine.resources.requests.gpu) 0 }} nvidia.com/gpu: {{ $.Values.engine.resources.requests.gpu }} {{- end }} From e819e50df8a2c6b2a9fe86d350a70712a49d0c65 Mon Sep 17 00:00:00 2001 From: Brian White Date: Mon, 15 Sep 2025 14:13:20 -0400 Subject: [PATCH 3/4] Correct context reference for engine resources --- .../templates/engine/engine.deployment.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/charts/deepgram-self-hosted/templates/engine/engine.deployment.yaml b/charts/deepgram-self-hosted/templates/engine/engine.deployment.yaml index ed1c8f3..709afd1 100644 --- a/charts/deepgram-self-hosted/templates/engine/engine.deployment.yaml +++ b/charts/deepgram-self-hosted/templates/engine/engine.deployment.yaml @@ -113,10 +113,10 @@ spec: nvidia.com/gpu: {{ $.Values.engine.resources.requests.gpu }} {{- end }} limits: - {{- if .Values.engine.resources.limits.memory }} + {{- if $.Values.engine.resources.limits.memory }} memory: "{{ $.Values.engine.resources.limits.memory }}" {{- end }} - {{- if .Values.engine.resources.limits.cpu }} + {{- if $.Values.engine.resources.limits.cpu }} cpu: "{{ $.Values.engine.resources.limits.cpu }}" {{- end }} {{- if gt (int $.Values.engine.resources.limits.gpu) 0 }} @@ -161,13 +161,13 @@ spec: {{- $gcpGpdEnabled := $.Values.engine.modelManager.volumes.gcp.gpd.enabled }} {{- $enabledCount := (int $customClaimEnabled) | add (int $awsEfsEnabled) | add (int $gcpGpdEnabled) }} - + {{- if eq $enabledCount 0 }} {{- fail "Error: At least one of customVolumeClaim.enabled, aws.efs.enabled, or gcp.gpd.enabled must be set to true." }} {{- else if gt $enabledCount 1 }} {{- fail "Error: Only one of customVolumeClaim.enabled, aws.efs.enabled, or gcp.gpd.enabled can be set to true." }} {{- end }} - + {{- if $customClaimEnabled }} {{- if not $customClaimName }} {{- fail "Error: customVolumeClaim.name must be set when customVolumeClaim.enabled is true." }} From 395e80ebe6d9d9e19f07244e78e4c0a090e4ac19 Mon Sep 17 00:00:00 2001 From: jkroll-deepgram Date: Wed, 17 Sep 2025 12:01:24 -0500 Subject: [PATCH 4/4] Add changelog line --- charts/deepgram-self-hosted/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/charts/deepgram-self-hosted/CHANGELOG.md b/charts/deepgram-self-hosted/CHANGELOG.md index a929f07..5e72a83 100644 --- a/charts/deepgram-self-hosted/CHANGELOG.md +++ b/charts/deepgram-self-hosted/CHANGELOG.md @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), - Added `externalTrafficPolicy` configuration for LoadBalancer services to control traffic routing behavior - Updated sample configurations to demonstrate service configuration options including LoadBalancer security settings - Container-level security context support to Helm templates +- Supported removing resource limits on Engine pods ### Changed