Skip to content

remove no_log on port module param #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove no_log on port module param #46

wants to merge 1 commit into from

Conversation

@JanSkalny
Copy link

@JanSkalny JanSkalny commented Dec 24, 2023 •
edited
Loading

Description

Remove no_log on port number parameter.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#45

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

dbrennand
dbrennand approved these changes Aug 27, 2025
View reviewed changes
Copy link

@dbrennand dbrennand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - What's the hold up on this one folks?

anupamaloke
anupamaloke approved these changes Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@anupamaloke anupamaloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anupamaloke anupamaloke removed the request for review from Pavan-Mudunuri August 29, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anupamaloke anupamaloke anupamaloke approved these changes

@Jennifer-John Jennifer-John Jennifer-John approved these changes

@Bhavneet-Sharma Bhavneet-Sharma Bhavneet-Sharma approved these changes

@meenakshidembi691 meenakshidembi691 Awaiting requested review from meenakshidembi691 meenakshidembi691 is a code owner

@trisha-dell trisha-dell Awaiting requested review from trisha-dell trisha-dell is a code owner

+2 more reviewers

@dbrennand dbrennand dbrennand approved these changes

@kuttattz kuttattz kuttattz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JanSkalny @anupamaloke @Jennifer-John @dbrennand @Bhavneet-Sharma @kuttattz