Remove unused code related to handling API responses

Author: ShocOne

apiintegrations/apihandler/apihandler.go

@@ -15,7 +15,6 @@ type APIHandler interface {
 	ConstructAPIAuthEndpoint(instanceName string, endpointPath string, log logger.Logger) string
 	MarshalRequest(body interface{}, method string, endpoint string, log logger.Logger) ([]byte, error)
 	MarshalMultipartRequest(fields map[string]string, files map[string]string, log logger.Logger) ([]byte, string, error)
-	//HandleAPISuccessResponse(resp *http.Response, out interface{}, log logger.Logger) error
 	GetContentTypeHeader(method string, log logger.Logger) string
 	GetAcceptHeader() string
 	GetDefaultBaseDomain() string

apiintegrations/jamfpro/jamfpro_api_response.go.back

@@ -388,61 +388,3 @@ func (c *Client) do(req *http.Request, log logger.Logger, method, endpoint strin
 
 	return resp, nil
 }
-
-// handleErrorResponse processes and logs errors from an HTTP response, allowing for a customizable error message.
-//
-// Parameters:
-// - resp: The *http.Response received from the server.
-// - log: An instance of a logger (conforming to the logger.Logger interface) for logging the error details.
-// - errorMessage: A custom error message that provides context about the error.
-// - method: The HTTP method used for the request, for logging purposes.
-// - endpoint: The endpoint the request was sent to, for logging purposes.
-//
-// Returns:
-// - An error object parsed from the HTTP response, indicating the nature of the failure.
-// func (c *Client) handleErrorResponse(resp *http.Response, out interface{}, log logger.Logger, method, endpoint string) error {
-// 	if err := c.APIHandler.HandleAPIErrorResponse(resp, out, log); err != nil {
-// 		log.Error("Failed to unmarshal HTTP response",
-// 			zap.String("method", method),
-// 			zap.String("endpoint", endpoint),
-// 			zap.Error(err),
-// 		)
-// 		return err
-// 	}
-// 	log.Info("HTTP request succeeded",
-// 		zap.String("method", method),
-// 		zap.String("endpoint", endpoint),
-// 		zap.Int("status_code", resp.StatusCode),
-// 	)
-// 	return nil
-// }
-
-// handleSuccessResponse unmarshals a successful HTTP response into the provided output parameter and logs the
-// success details. It's designed for use when the response indicates success (status code within 200-299).
-// The function logs the request's success and, in case of unmarshalling errors, logs the failure and returns the error.
-//
-// Parameters:
-// - resp: The *http.Response received from the server.
-// - out: A pointer to the variable where the unmarshalled response will be stored.
-// - log: An instance of a logger (conforming to the logger.Logger interface) for logging success or unmarshalling errors.
-// - method: The HTTP method used for the request, for logging purposes.
-// - endpoint: The endpoint the request was sent to, for logging purposes.
-//
-// Returns:
-// - nil if the response was successfully unmarshalled into the 'out' parameter, or an error if unmarshalling failed.
-// func (c *Client) handleSuccessResponse(resp *http.Response, out interface{}, log logger.Logger, method, endpoint string) error {
-// 	if err := c.APIHandler.HandleAPISuccessResponse(resp, out, log); err != nil {
-// 		log.Error("Failed to unmarshal HTTP response",
-// 			zap.String("method", method),
-// 			zap.String("endpoint", endpoint),
-// 			zap.Error(err),
-// 		)
-// 		return err
-// 	}
-// 	log.Info("HTTP request succeeded",
-// 		zap.String("method", method),
-// 		zap.String("endpoint", endpoint),
-// 		zap.Int("status_code", resp.StatusCode),
-// 	)
-// 	return nil
-// }