Skip to content

Commit 0a1cb0b

Browse files
authored
Merge pull request #625 from devrnt/feature/side-effect-free
Set side effect free
2 parents 744b87e + c8b050d commit 0a1cb0b

File tree

5 files changed

+12
-3
lines changed

5 files changed

+12
-3
lines changed

.changeset/unlucky-shoes-nail.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'react-use-intercom': major
3+
---
4+
5+
Update built target to es2017

.github/workflows/deploy.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@ jobs:
2929
- name: Install dependencies
3030
run: pnpm install --frozen-lockfile
3131

32-
- name: Build
33-
run: pnpm build
34-
3532
- name: Build playground
3633
run: pnpm build:playground
3734

apps/playground/vite.config.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,9 @@ export default defineConfig({
66
preview: {
77
port: 5173,
88
},
9+
server: {
10+
// https://vitejs.dev/guide/static-deploy.html#github-pages
11+
base: '/react-use-intercom/',
12+
},
913
plugins: [react()],
1014
});

packages/react-use-intercom/cypress/e2e/visitorId.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ describe('getVisitorId', () => {
2626

2727
cy.get('[data-cy="visitorId"]').click();
2828

29+
cy.wait(2000);
30+
2931
cy.get('[data-cy="visitorIdValue"]').should('exist');
3032
});
3133
});

packages/react-use-intercom/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
"license": "MIT",
99
"main": "dist/index.js",
1010
"types": "dist/index.d.ts",
11+
"sideEffects": false,
1112
"repository": {
1213
"type": "git",
1314
"url": "https://github.com/devrnt/react-use-intercom"

0 commit comments

Comments
 (0)