Skip to content

Commit 73d7c80

Browse files
author
Vanessa Bedzra
committed
fix merge conflict
1 parent c06a0e1 commit 73d7c80

File tree

3 files changed

+19
-5
lines changed

3 files changed

+19
-5
lines changed

README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ Testing
5050

5151
To run all the tests the only thing you need to do is run::
5252

53-
pip install -r tests/requirements.txt
53+
pip install -r tests/requirements/requirements_base.txt
5454
python test_settings.py
5555

5656

djangocms_versioning/cms_toolbars.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
)
3838
from djangocms_versioning.models import Version
3939

40+
4041
VERSIONING_MENU_IDENTIFIER = "version"
4142
CMS_SUPPORTS_DELETING_TRANSLATIONS = version.Version(cms_version) > version.Version("4.1.4")
4243
CMS_ADDS_PREVIEW_BUTTON = version.Version(cms_version) >= version.Version("4.2")
@@ -448,11 +449,15 @@ def add_language_menu(self):
448449
return
449450

450451
languages = get_language_tuple(self.current_site.pk)
452+
page_languages = self.request.current_page.get_languages()
451453
if len(languages) < 2:
452454
return # No need to show the language menu if there is only one language
453455

456+
if len(page_languages) < 2:
457+
return # No need to show language menu if current page has one language
458+
454459
language_menu = self.toolbar.get_or_create_menu(
455-
LANGUAGE_MENU_IDENTIFIER, _("Language"), position=-1
460+
LANGUAGE_MENU_IDENTIFIER, _("Languages"), position=-1
456461
)
457462
for code, name in languages:
458463
# Get the page content, it could be draft too!

tests/test_toolbars.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -497,17 +497,25 @@ def _get_toolbar_item_by_name(self, menu, name):
497497

498498
@override_settings(CMS_LANGUAGES = {1: [{"code": "en", "name": "English"}]})
499499
def test_change_language_menu_page_toolbar_one_languages(self):
500-
page_content = PageContentWithVersionFactory()
500+
page_content = PageContentWithVersionFactory(content__language="en")
501+
page = page_content.page
502+
503+
page.update_languages(["en"])
504+
501505
request = self.get_page_request(
502-
page=page_content.page,
506+
page=page,
503507
path=get_object_edit_url(page_content),
504508
user=self.get_superuser(),
505509
)
506510
request.toolbar.set_object(page_content)
507511
request.toolbar.populate()
508512
request.toolbar.post_template_populate()
513+
509514
language_menu = request.toolbar.get_menu(LANGUAGE_MENU_IDENTIFIER)
510-
self.assertIsNone(language_menu)
515+
self.assertIsNone(
516+
language_menu,
517+
"Language menu should not be created if the page has only one language."
518+
)
511519

512520
def test_change_language_menu_page_toolbar(self):
513521
"""Check that patched PageToolbar.change_language_menu only provides
@@ -556,6 +564,7 @@ def test_change_language_menu_page_toolbar(self):
556564
lang_code = "fr" if "Française" in item.name else "it"
557565
self.assertIn(f"language={lang_code}", item.url)
558566

567+
559568
@skipIf(cms_version <= Version("4.1.4"), "For CMS 4.1.5 and bove: Add delete translation menu")
560569
def test_change_language_menu_page_toolbar_including_delete(self):
561570
"""Check that patched PageToolbar.change_language_menu also provides

0 commit comments

Comments
 (0)