Skip to content

possible data race in AddStore() #206

@kmulvey

Description

@kmulvey

Im getting a race when running two tests in parallel that both create clients. Shouldn't there be a lock around that initializers map?

==================
WARNING: DATA RACE
Write at 0x00c00008b198 by goroutine 7:
  github.com/kmulvey/scratch/election.TestJoinElection()
      /opt/code/go/pkg/mod/github.com/docker/libkv@v0.2.1/libkv.go:39 +0xfd
  testing.tRunner()
      /usr/lib/golang/src/testing/testing.go:865 +0x163

Previous write at 0x00c00008b198 by goroutine 8:
  github.com/kmulvey/scratch/election.TestJoinElectionFail()
      /opt/code/go/pkg/mod/github.com/docker/libkv@v0.2.1/libkv.go:39 +0xf7
  testing.tRunner()
      /usr/lib/golang/src/testing/testing.go:865 +0x163

libkv/libkv.go

Line 39 in 4589771

initializers[store] = init

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions