Skip to content

Commit a6a0023

Browse files
committed
modules/settings.js: Refactors getAsBool to check that saved value IS bool
1 parent 0bd7762 commit a6a0023

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

lib/modules/settings.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,22 @@ aeq.settings = aeq.extend({}, {
6666
},
6767

6868
/**
69-
* Gets setting and returns as boolean
69+
* Gets setting and returns as boolean value, or undefined if not boolean
7070
* @method
7171
* @memberof aeq.settings
7272
* @param {string} sectionName Settings section name
7373
* @param {string} keyName Settings key name
7474
* @return {boolean|undefined} Saved setting as boolean
7575
*/
7676
getAsBool: function(sectionName, keyName) {
77-
return aeq.settings.get(sectionName, keyName) == "true";
77+
var value = aeq.settings.get(sectionName, keyName);
78+
79+
if (value === "true")
80+
return true;
81+
else if (value === "false")
82+
return false;
83+
84+
return undefined;
7885
},
7986

8087
/**

0 commit comments

Comments
 (0)