Skip to content

Conversation

@coolsoftwaretyler
Copy link
Contributor

@coolsoftwaretyler coolsoftwaretyler commented Dec 6, 2024

Reopening #117, which got kind of messed up in some rebasing.

This will:

  1. Add more checks for different pod install configurations like we did in react-native-ios-utilities
  2. Fix import paths

@coolsoftwaretyler coolsoftwaretyler changed the title fix: framework support, runtime crashes draft: fix: framework support, runtime crashes Dec 6, 2024
@coolsoftwaretyler
Copy link
Contributor Author

Hey @dominicstop - I added the same GitHub action you put together for react-native-ios-utilities to test more configurations for pod install, and I made the same header import fixes here. I had opened this in a separate PR but I think I pressed the wrong button on my fork and lost that work.

@coolsoftwaretyler coolsoftwaretyler changed the title draft: fix: framework support, runtime crashes fix: framework support, runtime crashes Dec 6, 2024
@coolsoftwaretyler coolsoftwaretyler changed the title fix: framework support, runtime crashes fix: framework support Dec 6, 2024
@dominicstop
Copy link
Owner

dominicstop commented Dec 6, 2024

hello, thank you for bringing over your changes from ios-utilities to this repo, and adding fixes for dynamic libraries

i ran your changes locally, and tried building the example app w/ dynamic frameworks, but i got stuck w/ this build error: Undefined symbol: facebook::jsi::dynamicFromValue (it says it's inside reanimated, but i think it's a linking issue due to the current project settings)

Screenshot 2024-12-06 at 11 05 35 AM

i wanted to manually run the github workflow on this specific PR (for testing), but i couldn't figure it out... in the meantime, i added another workflow called: build-example-ios-for-pr

it should (hopefully) run when there's a comment like this: run-workflow:build-example-ios-for-pr (it looks like it has some issues)

Repository owner deleted a comment from github-actions bot Dec 6, 2024
Repository owner deleted a comment from github-actions bot Dec 6, 2024
Repository owner deleted a comment from github-actions bot Dec 6, 2024
Repository owner deleted a comment from github-actions bot Dec 6, 2024
Repository owner deleted a comment from github-actions bot Dec 6, 2024
Repository owner deleted a comment from github-actions bot Dec 6, 2024
Repository owner deleted a comment from github-actions bot Dec 6, 2024
Repository owner deleted a comment from github-actions bot Dec 6, 2024
Repository owner deleted a comment from github-actions bot Dec 6, 2024
Repository owner deleted a comment from github-actions bot Dec 6, 2024
Repository owner deleted a comment from github-actions bot Dec 6, 2024
Repository owner deleted a comment from github-actions bot Dec 6, 2024
Repository owner deleted a comment from github-actions bot Dec 6, 2024
@dominicstop dominicstop force-pushed the master branch 2 times, most recently from 53aafd1 to e98d0b3 Compare December 6, 2024 04:28
@github-actions
Copy link

github-actions bot commented Dec 6, 2024

Run GH Workflow: build-example-ios-for-pr
https://github.com/dominicstop/react-native-ios-context-menu/actions/runs/12192961716

@github-actions
Copy link

github-actions bot commented Dec 6, 2024

@coolsoftwaretyler
Copy link
Contributor Author

Ah interesting. I tested this from a patch on my own app so I didn't try the example app in this library.

What are you using Reanimated for in the example? If it's not critical, maybe we can remove it and simplify the example app as a test ground.

@coolsoftwaretyler
Copy link
Contributor Author

The Reanimated failure seems related to this: software-mansion/react-native-reanimated#6062

It looks like 5aeff10 fixes the headers by using relative imports, so I might close this PR out if that works for you. I can open up another PR and see if I can fix reanimated in the example app.

@dominicstop
Copy link
Owner

hello, sorry for the delayed response; the ithub action for testing the diff. builds just stopped working recently, and i haven't been able to fix it yet.

i have reverted my changes, in favor of your fixes. i am currently waiting for all the build variants to complete; thank you for your patience.

@dominicstop dominicstop merged commit 6b3ff22 into dominicstop:master Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants