-
Notifications
You must be signed in to change notification settings - Fork 41
fix: framework support #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: framework support #118
Conversation
|
Hey @dominicstop - I added the same GitHub action you put together for |
|
hello, thank you for bringing over your changes from i ran your changes locally, and tried building the example app w/ dynamic frameworks, but i got stuck w/ this build error:
i wanted to manually run the github workflow on this specific PR (for testing), but i couldn't figure it out... in the meantime, i added another workflow called: it should (hopefully) run when there's a comment like this: run-workflow:build-example-ios-for-pr (it looks like it has some issues) |
53aafd1 to
e98d0b3
Compare
|
Run GH Workflow: build-example-ios-for-pr |
|
build-example-ios-for-pr: failed ❌
|
|
Ah interesting. I tested this from a patch on my own app so I didn't try the example app in this library. What are you using Reanimated for in the example? If it's not critical, maybe we can remove it and simplify the example app as a test ground. |
|
The Reanimated failure seems related to this: software-mansion/react-native-reanimated#6062 It looks like 5aeff10 fixes the headers by using relative imports, so I might close this PR out if that works for you. I can open up another PR and see if I can fix reanimated in the example app. |
|
hello, sorry for the delayed response; the ithub action for testing the diff. builds just stopped working recently, and i haven't been able to fix it yet. i have reverted my changes, in favor of your fixes. i am currently waiting for all the build variants to complete; thank you for your patience. |


Reopening #117, which got kind of messed up in some rebasing.
This will:
react-native-ios-utilities