Skip to content

Conversation

@Georgegriff
Copy link
Contributor

@Georgegriff Georgegriff commented Nov 14, 2025

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related # (issue) #10502

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue) <--- Hard to say if it's a breaking change it might be but current behaviour feels a bit wrong for interfaces
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

New unit test

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-codegen/...:
  • NodeJS:

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2025

🦋 Changeset detected

Latest commit: 0a421fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@graphql-codegen/visitor-plugin-common Patch
@graphql-codegen/typescript-document-nodes Patch
@graphql-codegen/gql-tag-operations Patch
@graphql-codegen/typescript-operations Patch
@graphql-codegen/typescript-resolvers Patch
@graphql-codegen/typed-document-node Patch
@graphql-codegen/typescript Patch
@graphql-codegen/graphql-modules-preset Patch
@graphql-codegen/client-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Georgegriff Georgegriff changed the title (WIP) Use parent type name on interface types without fragments Use parent type name on interface types without fragments Nov 25, 2025
@Georgegriff Georgegriff marked this pull request as ready for review November 25, 2025 18:59
@eddeee888
Copy link
Collaborator

eddeee888 commented Nov 27, 2025

Thanks @Georgegriff !

There's a minor thing to finalise this PR:

  • Adding a changeset to declare the version intention. Run yarn changeset and follow prompts to do this.

@Georgegriff
Copy link
Contributor Author

Thanks @Georgegriff !

There's a minor thing to finalise this PR:

  • Adding a changeset to declare the version intention. Run yarn changeset and follow prompts to do this.

@eddeee888 done... i think!

@eddeee888
Copy link
Collaborator

I've made it a patch since it's closer to fixing a bug

(could be argued as a new feature but we usually preserve minor for new config options)

@eddeee888 eddeee888 merged commit b995ed1 into dotansimha:master Nov 29, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants